- Issue was unassigned.
- 🇮🇳India sahil.goyal
Fixing all PHP coding standard issues attaching patch along with the comment.
- Status changed to Needs work
over 1 year ago 6:14am 27 February 2023 - 🇮🇳India hardikpandya
The patch isn't getting applied. Please work on making it compatible.
Also, @sahil.goyal it is a good practice to provide an interdiff from the previous patch submitted by a contributor to easily identify the changes done by you. See: https://www.drupal.org/node/1488712 →
- First commit to issue fork.
- Assigned to vishaljd
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:22pm 2 March 2023 - Status changed to Needs work
over 1 year ago 2:28pm 2 March 2023 - Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:24pm 3 March 2023 - 🇮🇳India imustakim Ahmedabad
phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig . No fixable errors were found Time: 7.09 secs; Memory: 22MB
Added a patch for fixes.
Please review. - Status changed to Needs work
over 1 year ago 4:26pm 3 March 2023 - Assigned to nitin_lama
- 🇮🇳India nitin_lama India
Patch #12 fixes all the phpcs related issues for branch 2.0.x.
- 🇮🇳India nitin_lama India
There are still issues in patch #14. @preethy_ray can you share an interdiff file or share what did you do in the patch ?
- 🇮🇳India nitin_lama India
I believe MR is ready for review. Please review.
- Issue was unassigned.
- Status changed to Needs review
12 months ago 11:16am 8 December 2023 - Status changed to Needs work
11 months ago 5:38am 4 January 2024 - 🇵ðŸ‡Philippines paraderojether
Hi nitin_lama,
I reviewed MR!130, applied against Facets 2.0.x-dev with Drupal core version 10.1.7 and there are still remaining phpcs errors/warnings shown below:
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/facets.routing.yml ------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------ 57 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction ------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/facets.install -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\block\Entity\Block. -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/query_type/SearchApiGranularTest.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerBuilder. ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/widget/LinksWidgetTest.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityStorageInterface. ------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/widget/WidgetTestBase.php ------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Entity\Facet. ------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/processor/ReplaceProcessorTest.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Entity\Facet. --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/processor/UidToUserNameCallbackProcessorTest.php ----------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityStorageInterface. ----------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/processor/DependentFacetProcessorTest.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\Entity\ConfigEntityType. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/processor/ListItemProcessorTest.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 19 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigManager. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Utility/FacetsUrlGeneratorTest.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityStorageInterface. -------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Functional/UrlIntegrationTest.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Entity\Facet. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Kernel/Entity/FacetFacetSourceTest.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Exception\Exception. ------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Kernel/Plugin/query_type/SearchApiDateTest.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\FacetInterface. --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/tests/src/Unit/Plugin/Processor/ResetFacetsProcessorTest.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerBuilder. ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/tests/src/Unit/Plugin/Processor/ShowTextWhenEmptyProcessorTest.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerBuilder. ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/tests/src/Functional/HierarchicalFacetIntegrationTest.php --------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Tests\facets\Functional\FacetsTestBase. --------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/tests/src/Functional/IntegrationTest.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets_summary\Entity\FacetsSummary. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/src/Form/FacetsSummarySettingsForm.php -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. -------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/src/Form/FacetsSummaryForm.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/src/Processor/ProcessorInterface.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\PluginInspectionInterface. ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/src/Plugin/Block/FacetsSummaryBlockDeriver.php ---------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\PluginBase. ---------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/src/FacetsSummaryManager/DefaultFacetsSummaryManager.php -------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------------------- 13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets_summary\FacetsSummaryInterface. -------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_searchbox_widget/tests/src/Unit/Plugin/widget/SearchboxLinksWidgetTest.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityStorageInterface. ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_range_widget/tests/src/Unit/Plugin/processor/RangeSliderProcessorTest.php ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\UrlHelper. ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_range_widget/tests/src/Unit/Plugin/processor/SliderProcessorTest.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerBuilder. ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/facets.module ----------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------- 20 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. ----------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Form/FacetForm.php -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------- 13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\FacetSource\SearchApiFacetSourceInterface. -------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/FacetSource/FacetSourcePluginBase.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\ContainerFactoryPluginInterface. -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Processor/ProcessorPluginBase.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\DependencyTrait. ---------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Processor/ProcessorInterface.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\PluginInspectionInterface. ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/facet_source/SearchApiBaseFacetSource.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\FacetSource\FacetSourcePluginBase. ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/CountWidgetOrderProcessor.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Processor\SortProcessorInterface. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/ActiveWidgetOrderProcessor.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Processor\SortProcessorInterface. ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/DependentFacetProcessor.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\FacetManager\DefaultFacetManager. -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/TranslateEntityAggregatedFieldProcessor.php ------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------ 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface. ------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/DateItemProcessor.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. -------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/CombineFacetProcessor.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\FacetManager\DefaultFacetManager. ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/BooleanItemProcessor.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/RawValueWidgetOrderProcessor.php ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Processor\SortProcessorInterface. ------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/Block/FacetBlock.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------ 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/FacetListBuilder.php ----------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Html. ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Event/GetFacetCacheContexts.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Event/UrlCreated.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Event/QueryStringCreated.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Event/PostBuildFacet.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Event/GetFacetCacheTags.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Event/GetFacetCacheMaxAge.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Utility/FacetsUrlGenerator.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------- 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpFoundation\RequestStack. ---------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------- Time: 6.78 secs; Memory: 20MB
Moving this to Needs work.
Kindly check and advise, please.
Thank you. - 🇮🇹Italy apaderno Brescia, 🇮🇹
I got 59 warnings/errors from PHP_CodeSniffer, not 30-something the issue summary shows.
- Status changed to Needs review
10 months ago 8:50am 5 February 2024 - 🇮🇳India pray_12
Fixed all the phpcs and phpcbf errors.
Please review.
Thank you!!! - 🇮🇹Italy apaderno Brescia, 🇮🇹
In JavaScript,
true
,false
, andnull
are used.TRUE
,FALSE
, andNULL
are used in PHP.
JavaScript files have been removed from the report exactly for that reason: to avoid false positives PHP_CodeSniffer would report when it tries to apply PHP rules to JavaScript code. - Status changed to Closed: outdated
8 months ago 1:34pm 10 April 2024