Wrong file header returned, when converting an image for example to webp

@cilefen Just ran into this on a totally different server and hoster again. Should we consider adding this to the .htaccess until it's resolved upstream? (Eventually add a comment for that above)?

I got this issue as well, but it's strange because I had this scenario:

1. Added the crop effect to my image style
2. Navigated the site as logged in user
3. Network was showing that the webp images were loading as type webp
4. Switched to anonymous user and network was showing jpg, png etc.
5. Ran drush image:flush all then network was showing webp again
6. But then if went back to logged in, we're back to square one :)

<IfModule mod_mime.c>
  AddType image/webp .webp
</IfModule>

Solved my problem with Lighthouse.

Adding a patch to temporarily fix the issue.

Is this only an issue for apache2 servers? Nginx does not have .htaccess files

@Anybody, any chance that it is related to this issue?

🐛 Incorrect headers for image derivative if file stored in private filesystem Needs work

@poker10 re #20 I don't think so, as the file was not stored in the private file system, see #8

+1 for this patch, my live host had the same issue. The images are correctly converted, just the returned mime type was incorrect. It seems many hosts don't properly configure mime types.

rcodina → changed the visibility of the branch 3310963-wrong-file-header-for-converted-images to hidden.

I added a new branch which comes from latest 11.x and I added there the patch on #17. The old branch had too many conflicts with 11.x so I have hidden it.

I confirm the patch works on Drupal 10.2.2 but I have to apply it manually. I also confirm the problem happens only under apache, under nginx it does not happen.

@rcodina do we still need to re-roll the patch so you don't need to apply it manually?

What are the next steps here? Happy to help, big fan of WebP.

@rmontero The patch on #17 missed to change the scaffold version of .htaccess but I did it in the issue branch I created to pass all the core tests. The MR is now fine, so there is nothing more to do. Maybe core maintainers will request us to add a test but I don't know where to begin because it's a problem which only happens under apache server and I'm not used to add core tests.

On the other hand, depending on core version, it's normal that some patches have to be applied manually. So don't worry.

Reading the threads believe the MR is on track.

As far as tests go I also don't know if we test specific setup like that. Will mark then.

Uploading a patch usable with composer for projects using drupal/core-recommended and drupal/core-scaffold that only updates the scaffold files version of the file.

FWIW, I checked the apache httpd source to make sure they do have webp in the default mime.types file, and it was added 13 years ago... https://github.com/apache/httpd/commit/217485c7e1f2f499049b4ff745076e4ed...

@mfb: Read #12

@Anybody ok so you're using ubuntu /etc/mime.types, not apache. In that case, looks like webp was added more recently, in January 2023, i.e. in Ubuntu 23.04 - https://salsa.debian.org/debian/media-types/-/commit/6883baf645560bcfe0a... - so it's finally fixed there too

This should have a more informative title, one that explains the change. This makes a huge difference with searching git logs.

Perhaps something like, "Attach correct header in .htaccess when mime module is enabled".

@quietone like this?

I sadly don't have the permission to change the MR title / commit message.

Thanks @Anybody title looks much clearer

All .htaccess changes need

• a change record, for example https://www.drupal.org/node/3351478 →
• a release note in the issue summary, for example https://drupal.org/node/3336463

Added draft CR and release notes snippet.

Release notes and CR added, CR correctly added for 10.4.x also.

Actually I don't think the CR should necessarily be for 10.4.x. Maintenance minors should only include four kinds of changes:

1. Security and upgrade path fixes.
2. Non-disruptive bug fixes that are backported to patch releases.
3. Dependency updates and PHP compatibility fixes.
4. Important API additions and deprecations for contrib compatibility across Drupal 10 and 11.

This doesn't seem to fall into any of those categories. I think this is probably an 11.1 fix only, since we're making an addition to the default .htaccess?

Left a question/observation on the MR

Believe feedback from @larowlan has been addressed.

This looks fine, all questions answered. I did update the CR to remove the diff and simplified the title. Adding tag for 11.1.0 release notes and updated credit.

One question on the MR.

@catch: Done! Back to RTBC?

Would say it could go back to RTBC. Comments were added for the 1 thread.

There were out of scope changes here and instead of setting back to NW I decided to fix that. Then I forgot that there are two .htaccess files to keep in sync. All should be fine now. Leaving at RTBC

Committed 30bea1e and pushed to 11.x. Thanks!

Not backporting to 10.4 as per @xjm in #44. Updated and published the change record.

Automatically closed - issue fixed for 2 weeks with no activity.