- 🇮🇳India gauravvvv Delhi, India
Updated the selectors and short-hand properties in #8. Attached interdiff for same
- Status changed to Needs work
over 1 year ago 1:02am 1 March 2023 - 🇺🇸United States smustgrave
.action-link { /* Action link states */ &:hover { text-decoration: none; color: var(--color-absolutezero-hover); background-color: var(--color-bgblue-hover); } &:focus { position: relative; z-index: 1; text-decoration: none; } &:active { color: var(--color-absolutezero-active); background-color: var(--color-bgblue-active); } }
/* Defaults for icons */ .action-link::before { position: relative; inset-block-start: 0.125rem; /* Set the proper vertical alignment */ display: inline-block; width: 1em; height: 1em; margin-inline: calc(var(--space-s) - var(--space-m)) 0.5em; background-repeat: no-repeat; background-position: center; background-size: contain; }
can be merged with line 33 I believe.
- Status changed to Needs review
over 1 year ago 5:16am 1 March 2023 - 🇮🇳India gauravvvv Delhi, India
I have improved the nesting. attached patch with interdiff. please review
- Status changed to Needs work
over 1 year ago 3:20pm 1 March 2023 - 🇺🇸United States smustgrave
More nesting can be done.
Code is too long but all the action-link--icon-* can be combined with their parents.
This many changes will need new before/after screenshots.
- Status changed to Needs review
over 1 year ago 12:34pm 2 March 2023 - Status changed to RTBC
over 1 year ago 8:05pm 2 March 2023 The last submitted patch, 16: 3303541-16.patch, failed testing. View results →
- First commit to issue fork.
- Status changed to Needs work
over 1 year ago 11:32am 21 March 2023 - 🇳🇿New Zealand quietone
@najni, This issue is using a patch workflow and was RTBC, there is no need for an MR. Therefor, credit has been removed per How is credit granted for Drupal core issues → .
- Status changed to RTBC
over 1 year ago 3:05am 22 March 2023 The last submitted patch, 16: 3303541-16.patch, failed testing. View results →
- Status changed to Fixed
over 1 year ago 8:16am 12 April 2023 - 🇪🇸Spain ckrina Barcelona
The "Needs follow-up label was added when the issue was created with this comment:
We need a followup issue to refactor this component in Drupal 10.0.x to make use of component-level CSS custom properties and remove IE specific style definitions.
Since this is exactly that, no follow-up needed.
Automatically closed - issue fixed for 2 weeks with no activity.