Claro details component does not have the right class

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

MR should be updated for 10.1

Updated Patch for drupal 10.1.x

Think this could also use a test case showing the issue.

I have tried to look into the issue manually but couldn't find the error you're describing.
I can see the error in the message area, but not on the element itself, moreover dumping errors variable from details.twig returns null (see screenshot). Could you give me a hint if I'm missing out on anything?

Re #13 enabling the Inline Form Errors module should get this to show up I just updated the issue summary to include this in steps to reproduce.

Test for this by expanding \Drupal\form_test\Form\FormTestDetailsForm to try with Claro in addition to the default test theme, and assert the expected class is present.

We are making changes in claro templates only.Do we need to do the same of default theme and then expand tests or shall we create a follow-up issue for default theme?

We are making changes in claro templates only.Do we need to do the same of default theme and then expand tests or shall we create a follow-up issue for default theme?

\Drupal\form_test\Form\FormTestDetailsForm already tests the default theme. it is simplest to add a few lines to that test to run the test with the default theme and then with Claro. Use a @dataProvider

Set up your dataProvider and put this at the beginning of the test to set the theme when $theme isn't false, and that does everything needed without having to add a new test class that is 99% the same as an existing one.

if ($theme) {
$this->config('system.theme')
      ->set('default', $theme)
      ->save();
}

smustgrave → changed the visibility of the branch 3298580-claro-details-component to hidden.

Added some nitpicky typehints

The failure is unrelated to this change.

  Drupal\FunctionalTests\Installer\InstallerTranslationExistingFileTest::testInstall
    Behat\Mink\Exception\ExpectationException: Current response status code is
    403, but 200 expected.

Believe this one is good.

nod_ → closed merge request !8037

Thanks for the fix and thanks for including a test, in this case the fix doesn't warrant a test and I removed it on commit.

Committed and pushed 8f25e5c227 to 11.x and 0c542167d6 to 11.0.x and 0dd26ceb53 to 10.4.x and 4f0a7ce2c8 to 10.3.x. Thanks!

nod_ → credited longwave → .

nod_ → credited quietone → .

credit to longwave and quietone for helping with testing decision

Automatically closed - issue fixed for 2 weeks with no activity.