- ๐ญ๐บHungary Gรกbor Hojtsy Hungary
Updating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-... โ
- ๐ณ๐ฟNew Zealand quietone
We should add the changes from ๐ [11.x] Remove forum CSS from themes and profiles Closed: duplicate and close that.
- First commit to issue fork.
- ๐ณ๐ฑNetherlands spokje
Spokje โ changed the visibility of the branch 11.x to hidden.
- ๐ณ๐ฑNetherlands spokje
Spokje โ changed the visibility of the branch 3261653-remove-forum-module to hidden.
- ๐ณ๐ฑNetherlands spokje
All test-failures are related to update-tests and thus to fixtures needing to be updated.
Which is great, because that should be all that was expected to be remaining.
So this is now, at the very least, postponed on ๐ Remove deprecated modules from update testing database dumps etc. Active .I've searched around for mentions of
forum
, but all/most of them seem to be migration related.
I'm sure more eyes will be prying the code-base to assure of that.For now I think this has been a very successful deprecation process, we seem to have ironed out most kinks we occurred during the Deprecation Dance D9=>D10, so well done all involved!
- ๐ณ๐ฟNew Zealand quietone
At first Forum was to be removed from theme as part of the deprecation process and therefore it has a separate issue, ๐ [11.x] Remove forum CSS from themes and profiles Closed: duplicate . But there is no need for it to be separate anymore so I have moved those changes to this MR.
Created the CR
- ๐ณ๐ฟNew Zealand quietone
There were 17 failed Functional tests before bringing in those changes and now there are 18. I have not looked into the details yet but let's continue here. I have closed the other issue as a duplicate and am moving credit.
- ๐ณ๐ฑNetherlands spokje
There were 17 failed Functional tests before bringing in those changes and now there are 18
Turns out
\Drupal\Tests\taxonomy\Functional\Update\NullDescriptionTest
was added between the testruns by me and @quietone.That one should fail (since it uses a 9.4.4 fixture) and it did, causing a +1 on test-failures.
So no new failures were introduced by merging ๐ [11.x] Remove forum CSS from themes and profiles Closed: duplicate into this MR. - ๐ณ๐ฟNew Zealand quietone
While we should run spellcheck it is unfortunate that the dictionary is out of sync again.
- Status changed to Needs work
7 months ago 2:48am 8 April 2024 - ๐ณ๐ฟNew Zealand RoSk0 Wellington
Needs rebase with conflict resolution.
Not postponed anymore as ๐ Move non-migration tests to Forum in preparation for deprecation Fixed have landed.
- Status changed to Postponed: needs info
7 months ago 7:40am 8 April 2024 - ๐ณ๐ฟNew Zealand quietone
The issue summary shows this as postponed on ๐ Remove deprecated modules from update testing database dumps etc. Active . We need the upgrade path and tests working first.
- Status changed to Needs work
7 months ago 5:42pm 19 April 2024 - Status changed to Needs review
7 months ago 6:41pm 19 April 2024 - Status changed to RTBC
7 months ago 9:06pm 19 April 2024 - ๐บ๐ธUnited States smustgrave
Cspell might be out of sync again. But removal seems good. Was previously green so doubt removing that word is going to break.
CR is there so removing tag.
Not sure what was needed for release note other then itโs been removed so leaving that.
- First commit to issue fork.
- Status changed to Fixed
7 months ago 8:44am 21 April 2024 -
alexpott โ
committed f1ac9b6c on 11.x
Issue #3261653 by Spokje, catch, larowlan, quietone, kim.pepper,...
-
alexpott โ
committed f1ac9b6c on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.