[11.x] Remove forum CSS from themes and profiles

Fix typo in title

Just moved claro but let me know if that works.

It looks good to go!

Still need to move olivero and stable9. But if we agree on the approach should be simple.

Background on the changes I did for hook_theme() was because not all themes had their own full set of forum templates. Claro actually had 4/5.

I find better to keep the same name for libs - less to add to change record

also it needs empty update hook to rebuild registry as files are moved and no need to apply https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... →

Wasn't 100% for that since it was classy code in claro but makes sense to me.

I made the same modifications to the olivero and stable9. If that is the right thing to do then that bulk work is done. However, there are failing tests. Leaving at NW.

Moved some more conditions to the hook_theme and updated the css path for olivero.

@Wim Leers did post one question on the Tour related ticket for hook_library_info_alter what should happen if there was a base theme to stable9?

quietone → credited catch → .

quietone → credited larowlan → .

quietone → credited lauriii → .

This was discussed in #need-review-queue-initiative in Slack, https://drupal.slack.com/archives/C04CHUX484T/p1708034907274609.

The conclusion was that this is best done in Drupal 11 when removing the extension from core. This applies to Book, Forum and Tour.

@catch @quietone @wimleers (he/him) so not sure what’s needed to move forward on 📌 Remove tour from themes Postponed any suggestion would be appreciated

Participants:

larowlan, smustgrave, quietone, catch, lauriii

Adding credit and changing parent.

Spokje → changed the visibility of the branch 11.x to hidden.

Spokje → changed the visibility of the branch 3409384-remove-forum-from to hidden.

Out of curiosity and to see if tests would break if we only deleted CSS I opened a new MR.

Deleted forum CSS from themes claro, olivero and stable9 and also from profile umami.
Tests are OK.

Am a bit unsure if this is still postponed now that 10.3.x is opened.
Can we diverge in 11.x for 11.0.x already?

Can we diverge in 11.x for 11.0.x already?

Yes!

Woohoo, thanks @catch!

Searched themes directory for forum and all css has been removed.

Found and removed 2 stragglers (forum-icons.png)

I moved these changes into the parent issue so we remove everything at once. I have moved credit over there. I am not sure what the best status is but duplicate seems the best.

smustgrave → closed merge request !6154