- 🇳🇿New Zealand quietone
Removed all the migration changes so they can be done in a separate test.
- Status changed to Needs review
almost 2 years ago 8:38am 6 February 2023 - 🇳🇿New Zealand quietone
The failing test was InstallUninstallTest. This tests that all modules can be installed and uninstalled. However, deprecated modules are excluded from the list of all modules so I think that the forum specific code should be removed when Forum is marked deprecated. For, now I have added @todo statements.
DependencyTest - This is testing core functionality of install and uninstall so I don't think that a forum specific version is needed. However, I have left the forum version in the MR in case that is wrong.
- Status changed to Needs work
almost 2 years ago 1:15am 7 February 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Left a review, thanks for working on this
- Status changed to Needs review
almost 2 years ago 10:52pm 7 February 2023 - 🇳🇿New Zealand quietone
Updated the MR and replied, so setting back to NR.
- Status changed to RTBC
almost 2 years ago 10:23pm 10 February 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Looks good to me, I agree, the existing coverage of path processing for /user is sufficient.
Thank you for working on this 💙
- Status changed to Needs work
almost 2 years ago 5:42pm 12 February 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to RTBC
over 1 year ago 10:59am 24 February 2023 - Status changed to Needs work
over 1 year ago 12:47pm 24 February 2023 - 🇬🇧United Kingdom longwave UK
The MR doesn't apply to 10.1.x, following 📌 Remove dead class PathProcessor in url_alter_test module Fixed where core/modules/system/tests/modules/url_alter_test/src/PathProcessor.php was removed.
- Status changed to Needs review
over 1 year ago 8:01am 27 March 2023 - 🇳🇿New Zealand quietone
Once again, GitLab has decided I can't push, after just pushing. Therefore, here is a patch.
- Status changed to RTBC
over 1 year ago 2:40pm 27 March 2023 - 🇺🇸United States smustgrave
Applied patch #29 and did a search for 'forum'.
All the instances I found (outside Forum module) were in migrate code. Assuming that is fine.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Removing credit for @ravi.shankar as this is 10.1.x only so a 10.0.x patch isn't needed.
-
larowlan →
committed 8a924f77 on 10.1.x
Issue #3264195 by quietone, joshua1234511, phenaproxima, smustgrave:...
-
larowlan →
committed 8a924f77 on 10.1.x
- Status changed to Fixed
over 1 year ago 4:58am 28 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.