- π³πΏNew Zealand quietone
I think this will be fixed by π Move migration code from content_translation to migrate_drupal Postponed
- Status changed to Needs review
7 months ago 3:47am 20 April 2024 - π³πΏNew Zealand quietone
Added a way to move this to migrate drupal.
This problem is about the source plugins, not migrations so I think we can just move the affected source plugins. I have not done the needed deprecations. I wanted to make sure there were no test failures.
- Status changed to Needs work
7 months ago 5:49pm 28 April 2024 - πΊπΈUnited States smustgrave
Nice no test failures. Moving to NW for deprecations mentioned in #17
godotislate β changed the visibility of the branch 3258581-move-contenttranslation-i18nquerytrait to hidden.
This is a blocker for π Convert MigrateSource plugin discovery to attributes Needs work , because instantiating reflection on classes that use I18nQueryTrait when content_translation is uninstalled cause a fatal error.
- π³πΏNew Zealand quietone
@godotislate, I see you are working on this issue. It is currently assigned to me and I have been working on it locally for a while. :-(
- Issue was unassigned.
- Status changed to Needs review
7 months ago 7:44am 3 May 2024 I have added deprecations to the moved classes and traits. Do deprecations still need tests? Or is phpstan covering that now?
And again, I apologize to @quietone for missing that you already were working on this and I didn't notice.
- Status changed to Needs work
7 months ago 8:01am 3 May 2024 - π³πΏNew Zealand quietone
@godotislate, no worries. It is just unfortunate that we both were doing the same thing. I think you got there first because I took a break to eat.
- Status changed to Needs review
7 months ago 9:49am 3 May 2024 - π«π·France andypost
Maybe it will be less disruptive to move file and provide alias via composer autoloader?
- Status changed to Needs work
6 months ago 5:17pm 3 June 2024 - πΊπΈUnited States mikelutz Michigan, USA
I'm not certain that we can do anything here, but we definitely can't do this. All of these sources being moved are scheduled to be deprecated and removed completely by d12 along with the migrate_drupal module, so we can't set a deprecation message telling people to use the migrate_drupal versions before d12 because those aren't going to exist anymore. I think at best we could introduce a copy of the trait to migrate_drupal and switch the sources over to it without doing any deprecation notices about moving things, and I'm not sure we should bother doing that at this point either.