Log out show error message "... your browser must accept cookies ..."

Patch #4 works on Drupal 9.5.8. We were having a problem where hitting /user/logout triggers the "To log in to this site..." message, after the user is properly logged out. A closer look into Drupal core showed that Drupal/Core/Session/SessionManager::destroy() calls session_destroy() instead of Session::invalidate() due to unwanted side-effects (details there); due to this, I also checked and found that both the session record and the browser-session-cookie are correctly cleared, which means the patch doesn't cause redundant session rows or bad impacts on caching.

I also ran some testing in a simplytest.me instance (vanilla 9.5.10-dev) and found:

• Chrome set to block cookies gets to show the "To log in to this site..." error message after submitting /user/login with valid login credentials.
• Chrome with cookies allowed: on logout, everything is properly cleared: browser-cookie as well as session record (checked this using views_sessions module).

Given all of the above, I think #4 is in great shape. Hopefully we can get some tests written, so it can be reviewed for merging.

Since Drupal 9 will be EOL soon, I think this needs to target D11 and get a backport to D10

Thanks, PAtch #4 worked for me.
Drupal 10.1.1)

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Previously tagged for tests. When changing to review please take a look at the issue summary and tags to make sure it’s ready.

#4 Works, Thanks!

andrew.farquharson → made their first commit to this issue’s fork.

Merge request !5634 has patch #4 applied.

The proposed fix at #18 seems the best solution. It fixes the original issue as strictly described. I have tested site instalaltion using drush site:install (Drupal 11.x) command. The bug does not occur. I believe that fix #18 since it targets the file that controls site installation done via the Drupal UI. Fix at #4 is far more general in its action and could have side-effects.

@smustgrave I am not sure how to test the installation via the Drupal UI? Is it possible to create a test that tests the equivalent of a Drupal UI installation? If a test is not feasible, it is simple to re-create the issue using the summary and testing manually.

There is a more general issue, possibly, as described at #22. But that should be dealt with as a new issue.

I have applied the one liner fix at #18. I have not added any test because I do not know how a fresh installation using the UI is possible in, say, a kernel test. Unless someone knows how to create such a test, please review and test the fix manually.

To see how the issue is isolated to installations via the UI, try a site install using drush and note that the issue does not arise.

Still putting in NW as tests will be needed.

But does anyone have a suggestion for #41

Know can do a fresh install using functional tests.

@andrewfarq,

Not sure what happened with [!5634], but it looks to have ended up only adding testSessionManagerInvalidateSessionOnDestroy(), and no other changes.

Also, your proposal in #40 🐛 Log out show error message "... your browser must accept cookies ..." Needs work may ignore other's experiences with this issue outside of the install process , such as after upgrade #21 🐛 Log out show error message "... your browser must accept cookies ..." Needs work or with anonymous users #22 🐛 Log out show error message "... your browser must accept cookies ..." Needs work . Or is that what #18 🐛 Log out show error message "... your browser must accept cookies ..." Needs work is proposing? I may have misunderstood that.

@jcandan I have applied a one-liner fix. the fix

This is the fix suggested at #18

Also, your proposal in #40 may ignore other's experiences with this issue...

The issue description contains steps to reproduce: "Install a new site via the Drupal UI". So if others are experiencing related issues it might be best if those users create child issues so they can be fixed outside this issue.

Seems there are related or may be similar: https://www.drupal.org/project/drupal/issues/3397718 🐛 "To log in to this site, your browser must accept cookies from the domain" error message displayed when user goes back and reload the page Needs work

I have edited this issue after carrying out further manual testing on Drupal 11.

@prashant.c Thank you for #46. I have read it with interest. I was unable to reproduce issue 3397718 on Drupal 11. So, it may be isolated to Drupal 9.5.

@andrew.farquharson I tried it on branch 11.x but could not reproduce. Will try on the Drupal 10 and on https://www.drupal.org/project/drupal/releases/11.0.1

@prashant.c I have been testing on the Drupal 11.0.1.

I'm facing the same issue in the Drupal 10.3.0 version. Are any patches or fixes available for that?