Account created on 16 February 2012, almost 13 years ago
#

Merge Requests

More

Recent comments

πŸ‡ΊπŸ‡¦Ukraine cosolom

I'm not sure is my issue was project specific, but this patch help me on Drupal 10.3.1

πŸ‡ΊπŸ‡¦Ukraine cosolom

cosolom β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡¦Ukraine cosolom

Hi kenyoowen. Message in readme have been updated

πŸ‡ΊπŸ‡¦Ukraine cosolom

I created MR which can resolve issue. We reset stripe_intent in order data when user on payment select page. I tested this with Payment Elements, but need to check with other stripe plugins also.

πŸ‡ΊπŸ‡¦Ukraine cosolom

cosolom β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡¦Ukraine cosolom

I'm not sure that this is right or best solution, but this works for my case and maybe will be good start point for next enhancements and fixes for the issue.

πŸ‡ΊπŸ‡¦Ukraine cosolom

Maybe better to use latest version of Monolog? Looks like they fixed the issue https://www.drupal.org/project/monolog/issues/3366135 πŸ› NullLogger not implements LoggerChannelInterface Fixed

πŸ‡ΊπŸ‡¦Ukraine cosolom

Added extra service for local web server on Windows

πŸ‡ΊπŸ‡¦Ukraine cosolom

I think that even unique setting is missed - we can add error message to log and don't break Ajax request at all. This will increase stability for the project.

πŸ‡ΊπŸ‡¦Ukraine cosolom

@abramm why you don't want to merge this code? It's not new logic or condition. This is a simple additional part how a good PHP code should have. You can't just check element of array with ! sign if you don't really know if this variable exists. You can use !empty or (isset & have value) or ?? for set default value for suppress PHP warning. It should't even be covered with tests.

πŸ‡ΊπŸ‡¦Ukraine cosolom

Thanks all. Applied to 1.0-beta4

πŸ‡ΊπŸ‡¦Ukraine cosolom

Thanks all. BTW need to use alter and not invokeAll for such cases. Will be released shortly

πŸ‡ΊπŸ‡¦Ukraine cosolom

Thanks all. Updated in branch 2.x-dev. Will be released shortly

πŸ‡ΊπŸ‡¦Ukraine cosolom

Thanks all. Updated in dev. Will be released shortly

πŸ‡ΊπŸ‡¦Ukraine cosolom

Released branch 2.x with support D10, thanks all

πŸ‡ΊπŸ‡¦Ukraine cosolom

Patch from #6 works for me. Thanks. I also had the issue that page is broken because of

TypeError: Cannot read properties of undefined (reading 'TreeTable')
πŸ‡ΊπŸ‡¦Ukraine cosolom

Hi. Can you provide some PR's or more extend description what do you want to maintain?

Giving a link to issues for that project where you posted a patch or where you reviewed patches posted from other users demonstrate you are interested in improving the project, and you are actively involved in the project. Point out the motivation behind your request. (For example, you are already using the project and you want it to be well-maintained.)

See https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... β†’

πŸ‡ΊπŸ‡¦Ukraine cosolom

Related to this one https://www.drupal.org/project/s3fs_file_proxy_to_s3/issues/3229743 ✨ Support for S3 file system scheme Needs review

πŸ‡ΊπŸ‡¦Ukraine cosolom

Maybe it's core related. Which Drupal version do you use? You can create new issue for this

πŸ‡ΊπŸ‡¦Ukraine cosolom

I also have this. I use advagg. When I disabled aggregation on /admin/config/development/performance I don't have error. But with enabled (even if Advagg js minification disabled) I see the error in console and any view edit page is broken

Production build 0.71.5 2024