Refactor (if feasible) uses of the jQuery each function to use Vanilla/native

Needs Review.

Left some comments.

Addressed feedback.

Feedback appears to have been addressed.

few more things

Addressed feedback.

Believe all feedback has been addressed.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Resolved Conflicts.

Still appears to be open threads from _nod

All the threads are resolved.

The comments were not addressed. A bunch of 'index' parameters needs to be removed, I found a couple more this time too.

Will work on the feedback.

Addressed Feedback.

Will lean on @nod_ previous review. But appears threads have been addressed

I'll take care of the review/commit on this one

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

This merge request seems to rely heavily on using .toArray(), but I don't think that is supported in Firefox or Safari.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global...
https://caniuse.com/?search=toArray

I just want to check that our build tools have something in place to transpile this to FF/Safari-compatible code?

Besides that, we'll done, this is a very large piece of work.

That's this toArray :) https://api.jquery.com/toArray/ goes back to something like IE8 probably

smustgrave → changed the visibility of the branch 11.x to hidden.

Rebased to make sure no random failures popped up.

Will leave with @nod_ for review.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

There's usage in states.js that isn't being caught by eslint but should also be changed. Perhaps in other files as well - can't hurt to grep a bit to find out.

Addressed feedbacks.

Should the other toArray() changes in the MR be updated?

Should the other toArray() changes in the MR be updated?

Yes. They should all be refactored, not just the instance specifically called out in the MR.

Updated the leftover uses of toArray to get().How did i miss those :).

No worries! Rest of toArray() have been replaced.

Thanks for keeping up with this massive MR :)

Few more comments and we should be good to go.

All the test that are failing on Gitlab CI are passing on my local.

Believe additional feedback from @nod_ has been addressed.

Found more bugs. At this point I'm not convinced the .each() method is worth replacing given the size of this MR and all the things that it could break.

I pinged @bnjmnm so that he could give his opinion on it

First of all thank you all for the hard work on this one, I've had to push a number of patches like this and I know how hard it is to keep up.

I'm going to try and refocus the jQuery removal work and to do that I need to take a few decisions. I'm going to close this issue for a few reasons:

• This MR is big, it impact a very big number of subsystems and make the code more brittle. jQuery is good at dealing with undefined elements, empty sets and so on, the DOM isn't. We already had regressions from a previous patch with undefined elements
• The MR is too big to review and make sure there are no regressions (even with the tests we already have), it would create unstability that we don't have to endure
• Every time I review this MR, I find a new bug

I ported the credits to 📌 Credit for work on the reduce jQuery issues Active , which I will mark as fixed as soon as I go through all the others impacted jQuery issues.