- 🇺🇸United States xjm
Thanks @mherchel for the context. :)
Hiding patches for clarity. Saving credits for reviewers, but uncrediting #14 as it just duplicated the work in the MR in #12 and #13, which in turn were also just applying a one-word change to an issue fork instead even though I can still apply #2 to 10.1.x now. (Also uncrediting my own clicking of the MR rebase button.)
As a change to module CSS, this is allowed in a Drupal minor version (so 10.1.x).
- Status changed to RTBC
over 1 year ago 5:02pm 13 February 2023 - Status changed to Needs review
over 1 year ago 7:28am 14 February 2023 - 🇫🇮Finland lauriii Finland
Changing this to a bug since this is an accessibility improvement.
I'm wondering if we should be making this change to Stable 9 too? It seems like it would be a relatively low risk accessibility improvement that we could ship to all themes.
- Status changed to Needs work
over 1 year ago 4:02pm 14 February 2023 - 🇺🇸United States smustgrave
For accessibility my answer is always yes. If it can be added lets do it.
- Status changed to Needs review
over 1 year ago 8:52am 15 February 2023 - 🇮🇳India Gauravvv Delhi, India
Addressed #23, Updated changes in stable9 as well. Please review
- Status changed to RTBC
over 1 year ago 5:21pm 15 February 2023 - 🇫🇮Finland lauriii Finland
Sorry, I forgot to mention in #23 that we would also need a change record since we are changing Stable. The CR should mention what the implications of this change is, and how someone with a theme extending Stable could revert to the old behavior if this is causing regressions for them.
- Status changed to Needs work
over 1 year ago 10:15am 18 February 2023 - 🇳🇿New Zealand quietone New Zealand
Setting to NW to get the change record written.
- 🇨🇦Canada mgifford Ottawa, Ontario