Use focus-within in hidden.module.css

Thanks @mherchel for the context. :)

Hiding patches for clarity. Saving credits for reviewers, but uncrediting #14 as it just duplicated the work in the MR in #12 and #13, which in turn were also just applying a one-word change to an issue fork instead even though I can still apply #2 to 10.1.x now. (Also uncrediting my own clicking of the MR rebase button.)

As a change to module CSS, this is allowed in a Drupal minor version (so 10.1.x).

Also happy to see Drupal get more accessible!

Changing this to a bug since this is an accessibility improvement.

I'm wondering if we should be making this change to Stable 9 too? It seems like it would be a relatively low risk accessibility improvement that we could ship to all themes.

For accessibility my answer is always yes. If it can be added lets do it.

Addressed #23, Updated changes in stable9 as well. Please review

Perfect

Fixing attribution.

Sorry, I forgot to mention in #23 that we would also need a change record since we are changing Stable. The CR should mention what the implications of this change is, and how someone with a theme extending Stable could revert to the old behavior if this is causing regressions for them.

Setting to NW to get the change record written.

Adding https://www.w3.org/WAI/WCAG21/Understanding/keyboard

#28

Created drafted Change Record → . Feel free to update the change record if needed.
https://www.drupal.org/node/3484054 →

Actually looking at the change introduced #32 and not sure why it's needed. Think it should be reverted.

Comment has been removed.

The mr should target the 11.x branch

As per comment #39 created a new MR for 11.x version.

smustgrave → closed merge request !3133

nod_ → closed merge request !10217

Committed fcde87f and pushed to 11.x. Thanks!

(changing my attribution to add my company)

Automatically closed - issue fixed for 2 weeks with no activity.