The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- @bhanu951 opened merge request.
- Status changed to Needs review
over 1 year ago 7:33am 7 February 2023 - Status changed to Needs work
over 1 year ago 4:06pm 15 February 2023 - Status changed to Needs review
over 1 year ago 7:43am 16 February 2023 - Status changed to RTBC
over 1 year ago 3:32pm 16 February 2023 - Status changed to Needs work
over 1 year ago 12:31am 8 March 2023 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Not sure that we can change only one call in \Drupal\KernelTests\Core\Theme\TwigEnvironmentTest - if they do return different values (which is possible) then the test will fail.
I'm not convinced that this issue is worth it - we have calls to sys_get_temp_dir() in unit tests that cannot be replaced here so I think we have an expectation that for testing sys_get_temp_dir() works and is writeable.