- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Seems like a valid thing, maybe even more for php8+
Tagging for framework manager for their thoughts?
Also not positive this will need a test or not.
- Status changed to Needs work
almost 2 years ago 11:58pm 30 January 2023 The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India pooja saraah Chennai
Fixed failed commands on #2
Attached patch against Drupal 10.1.x
Attached reroll patch - Status changed to Needs review
almost 2 years ago 7:08am 31 January 2023 - Status changed to Needs work
almost 2 years ago 8:23am 31 January 2023 - Status changed to Needs review
almost 2 years ago 3:19pm 31 January 2023 - 🇺🇸United States neclimdul Houston, TX
Link needs to point to a change record not the issue. Doesn't make sense to write the change record until the Framework Review has happened. So back to NR for the patch in #2.
- Status changed to Needs work
almost 2 years ago 11:23am 7 February 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 11:25am 7 February 2023 - Status changed to Needs work
almost 2 years ago 12:09pm 7 February 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 12:24pm 7 February 2023 - Status changed to Needs work
over 1 year ago 12:05am 3 March 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
+++ b/core/lib/Drupal/Component/Datetime/DateTimePlus.php @@ -49,8 +49,15 @@ class DateTimePlus { + * @deprecated in drupal:9.1.0 and is removed from drupal:10.0.0.
This will need updating now
We also need to check we're not using it anywhere in core
- Status changed to Needs review
over 1 year ago 4:54am 3 March 2023 - Status changed to Needs work
over 1 year ago 4:40pm 3 March 2023 - 🇺🇸United States smustgrave
Removing credit for #20 as it removed the deprecation
@larowlan these are the instances it's used so they will have to be updated too.
Since we are deprecating will need a change record too