Protect pager against [] for the page

Symfony\Component\HttpKernel\Exception\BadRequestHttpException: Input value "page" contains a non-scalar value. in Symfony\Component\HttpKernel\HttpKernel->handle() (line 83 of /app/vendor/symfony/http-kernel/HttpKernel.php).

Warning: explode() expects parameter 2 to be string, array given in Drupal\Core\Pager\PagerParameters->getPagerQuery() (line 58 of /home/catuser/app/public/docroot/core/lib/Drupal/Core/Pager/PagerParameters.php) #0 /home/catuser/app/public/docroot/core/includes/bootstrap.inc(600): _drupal_error_handler_real(2, 'explode() expec...', '/home/catuser/a...', 58, Array) #1 [internal function]: _drupal_error_handler(2, 'explode() expec...', '/home/catuser/a...', 58, Array) #2 /home/catuser/app/public/docroot/core/lib/Drupal/Core/Pager/PagerParameters.php(58): explode(',', Array) #3 /home/catuser/app/public/docroot/core/lib/Drupal/Core/Pager/PagerParameters.php(49): Drupal\Core\Pager\PagerParameters->getPagerQuery() #4 /home/catuser/app/public/docroot/core/lib/Drupal/Core/Pager/PagerManager.php(49): Drupal\Core\Pager\PagerParameters->findPage(0) #5 /home/catuser/app/public/docroot/core/modules/views/src/Plugin/views/pager/SqlBase.php(341): Drupal\Core\Pager\PagerManager->createPager('1470', 25, 0) #6 /home/catuser/app/public/docroot/core/modules/views/src/ViewExecutable.php(1422): Drupal\views\Plugin\views\pager\SqlBase->updatePageInfo() #7 /home/catuser/app/public/docroot/core/modules/views/src/ViewExecutable.php(1454): Drupal\views\ViewExecutable->execute(NULL) #8 /home/catuser/app/public/docroot/core/modules/rest/src/Plugin/views/display/RestExport.php(441): Drupal\views\ViewExecutable->render() #9 /home/catuser/app/public/docroot/core/modules/views/src/ViewExecutable.php(1630): Drupal\rest\Plugin\views\display\RestExport->execute() #10 /home/catuser/app/public/docroot/core/modules/views/src/Element/View.php(77): Drupal\views\ViewExecutable->executeDisplay('json_seo_dashbo...', Array) #11 [internal function]: Drupal\views\Element\View::preRenderViewElement(Array) #12 /home/catuser/app/public/docroot/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php(100): call_user_func_array(Array, Array) #13 /home/catuser/app/public/docroot/core/lib/Drupal/Core/Render/Renderer.php(781): Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_ren...', 'silenced_deprec...', 'Drupal\\Core\\Ren...') #14 /home/catuser/app/public/docroot/core/lib/Drupal/Core/Render/Renderer.php(372): Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) #15 /home/catuser/app/public/docroot/core/lib/Drupal/Core/Render/Renderer.php(200): Drupal\Core\Render\Renderer->doRender(Array, true) #16 /home/catuser/app/public/docroot/core/lib/Drupal/Core/Render/Renderer.php(144): Drupal\Core\Render\Renderer->render(Array, true) #17 /home/catuser/app/public/docroot/core/lib/Drupal/Core/Render/Renderer.php(573): Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() #18 /home/catuser/app/public/docroot/core/lib/Drupal/Core/Render/Renderer.php(145): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure)) #19 /home/catuser/app/public/docroot/core/modules/rest/src/Plugin/views/display/RestExport.php(424): Drupal\Core\Render\Renderer->renderRoot(Array) #20 /home/catuser/app/public/docroot/core/modules/views/src/Routing/ViewPageController.php(54): Drupal\rest\Plugin\views\display\RestExport::buildResponse('url_list', 'json_seo_dashbo...', Array) #21 [internal function]: Drupal\views\Routing\ViewPageController->handle('url_list', 'json_seo_dashbo...', Object(Drupal\Core\Routing\RouteMatch)) #22 /home/catuser/app/public/docroot/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array) #23 /home/catuser/app/public/docroot/core/lib/Drupal/Core/Render/Renderer.php(573): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #24 /home/catuser/app/public/docroot/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure)) #25 /home/catuser/app/public/docroot/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) #26 /home/catuser/app/public/vendor/symfony/http-kernel/HttpKernel.php(151): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #27 /home/catuser/app/public/vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) #28 /home/catuser/app/public/docroot/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #29 /home/catuser/app/public/docroot/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #30 /home/catuser/app/public/docroot/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #31 /home/catuser/app/public/docroot/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true) #32 /home/catuser/app/public/vendor/asm89/stack-cors/src/Asm89/Stack/Cors.php(49): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #33 /home/catuser/app/public/docroot/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Asm89\Stack\Cors->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #34 /home/catuser/app/public/docroot/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(52): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #35 /home/catuser/app/public/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #36 /home/catuser/app/public/docroot/core/lib/Drupal/Core/DrupalKernel.php(708): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #37 /home/catuser/app/public/docroot/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #38 {main}

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Comment about 1 year ago →
🇺🇸United States douggreen Winchester, VA
Attached patch fixes issue raised by the bot. It also cleans up the comment a tad.

* The both complained about the isset() which was introduced in #28, I've replace it with a simple condition because IMO neither isset() nor !empty is necessary here.
Status changed to Needs review about 1 year ago1:57pm 23 June 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
29,551 pass, 2 fail
Comment about 1 year ago →
🇺🇸United States douggreen Winchester, VA
Comment about 1 year ago →
System Message
The last submitted patch, 40: 3143617-40.patch, failed testing. View results →
Status changed to Needs work about 1 year ago10:33pm 23 June 2023
Comment about 1 year ago →
🇺🇸United States neclimdul Houston, TX
Its been 3 years so its hard to remember but pretty sure the isset was the to preserve the behavior of the empty check as demonstrated by the failing tests. What was the problem with it?
Comment 7 months ago →
🇮🇹Italy robertom
Attached patch fixes issues

Symfony\Component\HttpFoundation\Exception\BadRequestException: Input value "page" contains a non-scalar value.

raised by the test bot
Status changed to Needs review 7 months ago11:08pm 4 December 2023
Comment 7 months ago →
🇮🇹Italy robertom
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 7 months ago
Build Successful
Status changed to Needs work 7 months ago11:27pm 4 December 2023
Comment 7 months ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
Status changed to Needs review 7 months ago12:00am 5 December 2023
Comment 7 months ago →
🇮🇹Italy robertom
Attached a patch without the use of ->all()['page'] for avoid warning like

Undefined array key "page"
Status changed to Needs work 7 months ago2:12pm 5 December 2023
Comment 7 months ago →
🇺🇸United States smustgrave
Issue summary should be updated to the standard issue template, even if sections don't apply leaving them with NA is easier for reviews/committers.
Status changed to Needs review 7 months ago2:49pm 5 December 2023
Comment 7 months ago →
🇺🇸United States neclimdul Houston, TX
Updated.

Turns out its been long enough a few things have changed. Specifically, current versions of PHP throw an exception instead of a warning which makes it a bit harder to see. Specifically, real exception gets gobbled up by a more generic exception and Drupal's exception logging in watchdog doesn't show previous exceptions.

Since the actual exception is hidden and its hard to validate the root cause without hacking the exception handler or using a debugger, I've left the original trace in place. The fix is the same and the trace captures the essence of the problem.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 7 months ago
30,688 pass, 1 fail
Status changed to Needs work 7 months ago5:26pm 5 December 2023
Comment 7 months ago →
🇺🇸United States smustgrave
Ran patch #47 and it has a test failure that seems legit.

Recommended to convert to MRs
Merge request !5703Resolve #3143617 "Protect pager against" → (Open) created by neclimdul
Comment 7 months ago →
🇺🇸United States neclimdul Houston, TX
"pretty sure the isset was the to preserve the behavior of the empty check as demonstrated by the failing tests." 🤷

Added it back because it was there to defensively handle a null value from the getPagerParameter method. Since isset is a language level feature there's no real cost to being defensive like this.

I'm already tired of the 500 remotes and all the commit juggling. I'm going to really miss the simple patch workflow. But ok, its in a MR now.
Comment 7 months ago →
🇺🇸United States neclimdul Houston, TX
Turns around it was a little more complicated. I went ahead and took the opportunity to update the tests and make things a little more clear.
Status changed to Needs review 7 months ago3:22pm 6 December 2023
Comment 7 months ago →
🇺🇸United States neclimdul Houston, TX
Status changed to RTBC 7 months ago7:30pm 6 December 2023
Comment 7 months ago →
🇺🇸United States smustgrave
Thanks looks good!
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 7 months ago
30,696 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 7 months ago
30,698 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 7 months ago
30,698 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 6 months ago
30,712 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 6 months ago
30,726 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 6 months ago
30,766 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 6 months ago
25,905 pass, 1,817 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 6 months ago
25,884 pass, 1,814 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 6 months ago
25,945 pass, 1,825 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 6 months ago
25,909 pass, 1,807 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 6 months ago
25,914 pass, 1,799 fail
Status changed to Needs work 6 months ago3:28am 28 December 2023
Comment 6 months ago →
🇳🇿New Zealand quietone New Zealand
I'm triaging RTBC issues → . I read the IS, the comments and the MR.

Thanks for updating the Issue Summary, that is always helpful! The review in #28 by @neclimdul was also useful as it explained what they were thinking and checking. That provided me with insight into understanding the issue and when else I may need to check.

The changes to getPagerQuery and getPagerParameter are changing the behavior, making it conform to the interface. So, it there any ramification for contrib/custom?

I left suggestions in the MR for coding standards and one asking for documentation.

I hide all the patches.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 8
last update 5 months ago
Build Successful

Protect pager against [] for the page

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!5703Protect pager against [] for the page
Open

Comments & Activities

Protect pager against [] for the page

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!5703Protect pager against [] for the pageOpen

Comments & Activities

!5703Protect pager against [] for the page
Open