Machine name field expands after failing validation

This qualifies as a feature request I think. It also needs a reroll against 10.1.x

Attached patch against Drupal 10.1.x
Attached reroll patch
Removing the tag reroll

The last submitted patch, 22: 3038141-test-only.patch, failed testing. View results →

Didn't set things up for an interdiff, but the change was elminating the use of jQuery .val() per the eslint rules

Is this still addressing the same use case? It looks like the new approach in #22 would add stricter measures to when the machine name field should be invisible, rather than loosening those requirements. The use case in the issue summary seems to be that user clicks submit, but the form isn't actually submitted because of HTML 5 validation. This shouldn't result in the machine name field being revealed when the field for a human readable value is empty.

Verified MR!3406 and tested it on Drupal version 10.1.x. The patch works fine and I have added the before and after screen recordings for reference.

Merge request !3406 tested and applied clearly on drupal 10 version,
I have added some screenshots for references.

Thanks.

Posted review on the MR.

Appear to be 2 open threads in the MR 3406 if those can be looked at? @lauriii

Those threads should be addressed in the MR, marking back to NR.

Thanks @laurii for taking a look. Looks like there is 1 thread with an outstanding question.

There could be some crossover between this and 🐛 Machine name generation is way too slow Fixed , at least in so far as solution LOC intersection.

Confirmed with the MR the machine name doesn't appear for validation error.

Going to mark this but this may get sent back for issue summary update. proposed solution could be written out.

Updated issue summary. Also did a round of Screenreader/Keyboard Nav on HEAD vs this MR and confirmed there are no regressions with that experience.

Posted a question in the MR.

Tested locally and the fix still works. Ran the test "testMachineName" and it should still be green too

Can someone remove that require line from machine-name.js

Don't want to take myself out of the review role.

Change looks good and functions correctly.

Followed the steps of the issue summary.
Went to create a vocabulary
Clicked save (without filling anything in)
Machine name filed still does not appear.

lauriii → closed merge request !3406

Committed a650913 and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.