The position of the toolbar moves above the off-canvas top dialog if a modal dialog is opened

Created on 12 July 2018, over 6 years ago
Updated 14 August 2024, 4 months ago

Problem/Motivation

While reviewing #2949991: Add workspace UI in top dialog I found a bug with the toolbar and the off-canvas dialog.

The current patch updates the off_canvas_top to be able to demonstrate the problem without the workspaces module involved.

  1. Login with a user who has access to the toolbar
  2. Goto /off-canvas-test-links
  3. Click Open top panel 1
  4. When the top dialog opens notice the toolbar is at the bottom of the top dialog
  5. Click "Open modal!" on the main page
  6. Notice that now the toolbar is at the top of the top dialog.
  7. Close the dialog
  8. Notice that now the toolbar remains at the top of the top dialog.

This behavior happens whether the dialog link is the off-canvas dialog or on the main page.

Proposed resolution

Fix the margin-top of <nav id="toolbar-bar" role="navigation" aria-label="Toolbar items" class="toolbar-bar clearfix" data-offset-top="" style="margin-top: 0px;"> on dialog open/close.

Remaining tasks

User interface changes

Before

API changes

Data model changes

🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
Javascript 

Last updated 5 days ago

Created by

🇺🇸United States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024