The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to RTBC
over 1 year ago 3:46pm 7 March 2023 - 🇬🇧United Kingdom longwave UK
Re #23 and #24 there is ✨ Assert if a library definition is not valid / as expected Needs work which doesn't exactly cover this issue but could be expanded to do so, I think.
- First commit to issue fork.
- 🇫🇷France nod_ Lille
So nav tabs don't use details so the dependency is wrong
And I could not find any code using/including the
drupal.responsive-detaillibrary, so no harm removing the dependency. - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
I think that fix is fine for D10, but for D9 wasn't it required as a polyfill for the details element for IE11?
Still has the needs subsystem maintainer review tag, so will ping in slack
- 🇳🇿New Zealand quietone New Zealand
change title to indicate what this is fixing.
- Status changed to Fixed
over 1 year ago 7:17am 12 April 2023 - 🇫🇷France nod_ Lille
I don't think it's valuable to spend more time on it here, committing as is and added a followup 📌 Remove or fix claro/drupal.responsive-detail Fixed to figure out the actual place it may be useful. nav tabs definitely don't need this dependency.
As far as backport goes, since it doesn't anyone really noticed i say leave it as-is?
Removing seven from the title since it's only claro now :) (but the commit message went out with seven…)
Committed dc0c894 and pushed to 10.1.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.
