The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 7:10am 31 January 2023 The last submitted patch, 32: 2914824-32.patch, failed testing. View results →
- 🇫🇮Finland sokru
Removed the return typehint since it was expecting array, same as other functions in same class. I'd suggest adding return typehints in separate issue.
- Status changed to Needs work
almost 2 years ago 4:40pm 1 March 2023 - 🇺🇸United States smustgrave
Think the return types are needed. If they're returning something wrong is that not a sign something could be wrong?
Applied the patch but not seeing flip as an Image style option. Don't see anything in the Image toolkit either.
If this is providing new UI screenshots are going to be needed in the issue summary.
- Status changed to Needs review
almost 2 years ago 6:23am 2 March 2023 - 🇫🇮Finland sokru
1. The scope of the issue issue is just to add flip() method for image handling. Adding the separate image effect is discussed on ✨ Add Auto orientation image effect Needs work . In order to "manually" test this, the best way to is to install
drupal/exif_orientation
and use MR on 🐛 Flipped orientation flags ignored RTBC with patch from #34 and use the test images mentioned on 🐛 Didn't fix every EXIF orientation Active .
2. For adjusting the tests to handle correct return type hints I created a separate issue 📌 Add typehints to ImageInterface and adjust the tests Needs work , in hopes to get this issue committed during this decade. - Status changed to Needs work
over 1 year ago 7:37am 7 April 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 4:05pm 12 April 2023 - 🇫🇷France andypost
Removed useless code-comments and added display of debug of broken flip mode
Re #35 - type-hints can't be added without refactoring test suite and tests making
execute()
to return arguments instead of real value from conversion - Status changed to Needs work
over 1 year ago 6:10pm 12 April 2023 - 🇺🇸United States smustgrave
Thanks @andypost
Moving to NW for potential screenshots.
IS also mentions needing a change record.