Inappropriate trailing colons in Claro and Umami

Confirmed this is still happening in Claro/Umami (did not test Olivero). I added steps to reproduce in the IS. The only core instance of this seems to be in deprecated CKEditor 4 related forms, but this issue should remain open since .container-inline should fully support all core form elements, even if they don't happen to appear in an inline form.

This requires some extra steps to reproduce so I'm not sure what kind of momentum this issue will have going forward, but the problem still exists

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Made an updated MR with the changes from #2912824-22: Inappropriate trailing colons in Claro and Umami → just applied to the current core themes.

Wonder if this will require a simple test case to check if the colon is there or not. Or is that overkill?

Posted to #bugsmash and @mstrelan commented

The colon is never really there. I'm not sure if we can even check pseudo-elements? Either way I think PHP should trust that CSS is doing CSS things, it would be more appropriate to check that PHP / twig is outputting the appropriate markup so CSS can style it accordingly. That may already exist?

So since this is pure css don't think we need tests then.

But there was a CI failure in the MR.

Hiding the files as the work is being done in the MR now.

Oops! Fixed.

Thanks!

Changes requested in MR.

Also, lets celebrate that this is the rare occasion where I'm tagging "needs screenshots" instead of wearily pointing out there are too many of them. There should be shots for Claro and Umami with checkboxes and radios.

Please review.

Threads appear to be answered

Moving to NW per #39 for screenshots and issue summary update please.

I mentioned earlier that the Claro solution was using selectors that don't exist in Claro. It looks like the Claro changes were removed entirely, when the solution should be changing them to the correct selector.

Because the merge request is currently not mergeable I've created a new patch that applies to D10.1.x