Use comment access handler instead of hardcoding permissions

Is the patch still needed with Drupal 10?
As it is mentioned as 'required' by the https://www.drupal.org/project/group_comment → module, it would be great to have some update.
Thanks for any feedback.

Attached a patch for 10.1. Patch is based on 01ed69c2. Slightly adjusted for D10.

It seems I introduced a type error in the last patch when the account is not set. Updated patch. (Only addition
$account = $account ?: \Drupal::currentUser(); in CommentFieldItemList.php).

This patch is identical to #136, only I removed one change introduced by this commit. I'm not sure if that permission check is needed (as view access on the parent comment is checked), and feels like it goes against the idea of the patch itself (to use access checks instead of permission checks). We use this patch together with Group Comment module, and that check would only allow replying to comments if we'd use the 'View comments' global permission, and we'd like to avoid that in favor of group permissions.

Tested for version 10.3
#136 and #137 didn't apply...

this is 137 rerolled for 10.3.x

My patch in #139 was missing a use statement, this should work for 10.3.x

liam morland → made their first commit to this issue’s fork.

I have put the patch in #141 into the merge request. The person who opened the merge request, @claudiu.cristea, will need to update the merge request so that it targets branch 11.x.