Use the exact current time in KV and tempstore.

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Tagging for framework managers thoughts as this feels like something that could be disruptive for other sites.
Tagging for IS update for remaining tasks as this will have to be rescoped for D10
Tagging for change record update on if this moves forward it will need one for sure.

Patch for Drupal version 10.1.x

Resolved PHPCS errors from #38

Still needs issue summary update and change record

Trying to resolve CCF corresponding to #39, upload a patch and interdiff with it.

Fixed the custom commands on #41
upload a patch and interdiff with it.

I am on this. CR added. Constructor property promotion will be used.

Added "in short, REQUEST_TIME does not equal to the \Drupal::time()->getCurrentTime()." to the IS.

The last submitted patch, 46: 2855457-46.patch, failed testing. View results →

Oops. 2855457-48.patch is empty.

Removed credit for #38, #39, #41, and #42 as it's expected the patch to be tested locally before uploading.

The last patch doesn't pass commit checks, could you make sure to run ./core/scripts/dev/commit-code-check.sh before uploading a patch to make sure there are no issues with code formatting. see https://www.drupal.org/docs/develop/development-tools/running-core-devel... →

Reviewing #49
Changes look good but think we will need a simple kernel test (maybe Unit) for checking the deprecation of each of the constructors when a null time parameter is passed.

Going to post to the slack channel also for the framework feedback.

+++ b/core/lib/Drupal/Core/KeyValueStore/DatabaseStorageExpirable.php
@@ -24,9 +25,15 @@ class DatabaseStorageExpirable extends DatabaseStorage implements KeyValueStoreE
-  public function __construct($collection, SerializationInterface $serializer, Connection $connection, $table = 'key_value_expire') {
+  public function __construct($collection, SerializationInterface $serializer, Connection $connection, $table = 'key_value_expire', protected ?TimeInterface $time = NULL) {

The problem here is that we will have to remove the default for $table in Drupal 11 as you can't have mandatory arguments following optional ones. Is it worth doing the argument dance here so $time comes before $table?