Reset button shows on exposed filter defaults

Patch #57 did not apply on 10.1.x-dev successfully. Need to re-roll patch for 10.1.

Checking patch core/modules/views/src/Plugin/views/exposed_form/ExposedFormPluginBase.php...
error: while searching for:
      $all_exposed = array_merge($exposed_sorts, $exposed_filters);
      // Set the access to FALSE if there is no exposed input.
      if (!array_intersect_key($all_exposed, $this->view->getExposedInput())) {
        $form['actions']['reset']['#access'] = FALSE;
      }
    }
error: patch failed: core/modules/views/src/Plugin/views/exposed_form/ExposedFormPluginBase.php:281
error: core/modules/views/src/Plugin/views/exposed_form/ExposedFormPluginBase.php: patch does not apply
Checking patch core/modules/views/tests/src/Functional/Plugin/ExposedFormTest.php...

Addressed Comment #61
Attached patch against Drupal 10.1.x

The last submitted patch, 64: 2833388-64.patch, failed testing. View results →

Updated the link Next › to Next ›

FYI for the rerolls from #62-#67 please include interdiffs for the changes you make.

Patch #68 works for me where reset button does not appear on page 2 of admin view.

+1 for RTBC but can't move it was I worked on this.

Tested this locally on 10.1.x and it works as expected. Read through the patch, and the code seems solid.

This is a subtle but good usability improvement. Marking as RTBC.

The last submitted patch, 64: 2833388-64.patch, failed testing. View results →

The last submitted patch, 64: 2833388-64.patch, failed testing. View results →

I ran the test locally without the fix and it passes. I am setting this back to needs work.

+++ b/core/modules/views/tests/src/Functional/Plugin/ExposedFormTest.php
@@ -489,6 +489,13 @@ public function testExposedFilterPagination() {
+    $this->clickLink('Next ›');

Why is it necessary to click next?

Also just tested on 10.1.x and no longer seem to able to replicate. Can someone else give a shot?

Confirming it no longer occurs as of at least 10.1.x, wish it were possible to give credit to all those who participated in fixing this!

I've also retested in 11.0.0-alpha1 and can confirm. but i've noticed one other related detail which might probably require a new issue in case it not already exists. if you enter a search term, filter for it, then manually remove the string from the search field, press return, the whole list of nodes is shown again but the reset button is still shown and keeps showing even if you go to another page in the pagination.