prepareDialogButtons does not work for button elements.

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Reroll for 10.1

As a bug could we get a test case showing the issue?

The Claro theme converts the delete button from a.button to a.action-link (_claro_convert_link_to_action_link), I think they should also be moved to the action area.

I know it should probably be another issue, but if this issue ever manages to make it into core, it would be great if one small addition could be added:

          class: $originalButton.attr('class'),
          disabled: $originalButton.attr('disabled'),

allowing the dialog buttons to inherit the disabled attribute from the original button.

The issue with action links has been resolved here: https://www.drupal.org/project/drupal/issues/3359240 ✨ Enable bundle selection when a new view mode is created Fixed

I moved the fix from patches to the merge request

Let me work on suggestion #22.

@sourabhjain That suggestion needs a separate issue. All issues should focus on only fixing one specific thing, you should know that by now. Please revert, and if you're feeling like it, create a child issue for that.

Sure @bramdriesen. Let me revert it.

Reroll for 10.2