Entity Reference Views Limit not working

It's a shame this isn't fixed yet after years in core.
Any site builder CANNOT force an entity reference selection: even if his custom logic defined in a View results in 1 item, a checkbox on the entity form will list multiple options, that he cannot even see in the Views' preview!

Also, why can't this be fixed in 10.1.x instead of 11?!

I ran into this small issue using webforms to make a more visual selection of nodes. The patches are not working for 10.2.x. Would be great if this could be fixed , because showing ALL the results on a single page will result in performance issues.

I was able to fix this just by adding these lines to /core/modules/views/src/Plugin/EntityReferenceSelection/ViewsSelection.php

(after the $this->view->setDisplay($display_name);, before the $entity_reference_options = [)

    $this->view->initPager();
    $items_per_page = $this->view->getItemsPerPage();
    if ($items_per_page > 0) {
      $limit = $items_per_page;
    }

I have uploaded the patch
Address #53 comment
Please review

#53 and patch from #54 seem to be working

What do you mean?
There is no paging in entity references and if you set a limit in the View with "Display a specified number of items", you are explicitly removing the pager.
I just tested that the pager on another display (of type page) of the same View works.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Prem Suthar → made their first commit to this issue’s fork.

Create the Mr For Issue. Please Review

This will need test coverage

#54 appears to have dropped a good portion of the original patch, how come? @Prem Suthar see you opened an MR for that too so maybe you know too?

#54 appears to have dropped a good portion of the original patch

And this removal brought back the problem when the pager is not set, in which case the view returns all the results, instead of the specified limit in the widget.

I believe that in any case we should override the pager with parameters from the EntityReferenceSelection plugin.

And the implementation of what is described in the problem will cause confusion for users who want to determine the limit of results at the widget level.

I opened a new merge request that solves the problem where if a view doesn't have a pager set, all results are displayed.

smustgrave → changed the visibility of the branch 2772523-entity-reference-views to hidden.

Thanks @kksandr for restoring what was removed in 54 and previous MR

1) Drupal\Tests\field\Kernel\EntityReference\Views\ViewsSelectionLimitTest::testLimitedOutput
Failed asserting that actual size 20 matches expected size 10.
/builds/issue/drupal-2772523/core/modules/field/tests/src/Kernel/EntityReference/Views/ViewsSelectionLimitTest.php:84
FAILURES!
Tests: 1, Assertions: 8, Failures: 1.

Shows the test coverage so removing that tag.

Left some small comments on MR

Appears to be close!

Feedback appears to be addressed thanks!

The proposed resolution doesn't match the MR.

Also instead of dynamically changing the pager type, why not validate it when a view is selected?