Move Attribute classes under Drupal\Component

Rebased onto 10.1.x, will work on renaming classes to HtmlAttribute* as suggested in #3252386-148: Use PHP attributes instead of doctrine annotations → .

This patch is raising the new component's PHPStan compliance level to 9. This requires excluding PHPCS checks on it because they are incompatible to most PHPStan L6+ fixes. Keeping the patch separate from the MR since I am aware this is too far fatching ATM.

Spell check fixes.

Sorry.

The last submitted patch, 176: 2664570_176.patch, failed testing. View results →

Some improvements in scope/visibility of properties and constructors, driven by PHPStan.

Apparently, using phpstan prefixed annotations for params and returns, we can get code compliant with PHPStan-9 AND pass current Drupal PHPCS checks.

So I did that in the MR.

rebased

This issue is already compatible with 📌 [policy, no patch] Decide on a namespace for PHP Attribute classes Fixed but just noting the decision over here.

Removing the needs follow-up tag since that already exists per #100.

Wasn't entirely sure how to best test this one.

I applied the MR and did some basic features like creating content, media, using the workflow, etc.

Nothing seemed to break but if there's a more targeted way let me know!

+1 from me but with a large feature maybe should get a few more (and real testing)

I think the issue here is that we need some specialist information, such as whether the infrastructure is set up to add another packagist listing and whether the subtree split will work.

Back in the day, @Mixologic had that set up to happen smoothly, but since he's not at the DA any more, it unclear who to ask. Or at least I don't know who. :-)

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Maybe after commit of 📌 Update coder to 8.3.18 Fixed we can now go back to use standard @param and @return annotations.

Think this would be good to get in early for 10.2

Tried rebasing to see if the tests would run but seems to be an issue.

I think we can close this one for less disruption

Test failure seems legit to issue.

Thanks for updating!

Rebased. Now phpstan-deprecation is triggering a load of errors. Shall we ignore/baseline them for the moment, or do we need to address them here? (The latter may significantly increase the size of the MR)

Rebased.

Ignoring phpstan deprecation messages for the Attribute classes, per #194.

Think it needs a manual rebase as MR is showing unmergable.

I looked at it a while back and its kinda a big lift to rebase this. Without some interest in committing its hard to justify that time. I think its worth that effort but doing it now, 3 or 4 more times before commit is a big waste of time.

It seems like we need:

• Maintainer to say it's still in the cards.
• D.O ops person to reaffirm that a GitHub split will be created (automatically or otherwise) for the drupal/core-attributes package.
• Add your own thing here... :-)

Then after that is sorted, we'd need to perform a re-roll, and can do the code review and changes.

With that in mind, adding 'needs subsystem maintainer review' since there's not really an 'ask ops' tag, and adding NRQI tag and asking in slack so maybe some maintainer can please affirm that it's worth the time to do.

Asked just now on Slack, and @drumm says the GitHub split will happen automagically.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.