- 🇮🇳India sahil.goyal
Updating the patch against #42 trying to resolve the CCF errors.
- Status changed to Needs review
almost 2 years ago 7:34am 24 January 2023 - 🇮🇳India ankithashetty Karnataka, India
Thanks, @sahil.goyal for the fix. But the patch in #43 has additional changes like
StringTranslation
which is out-of-scope of this issue.Compared the old patches in #42, #25, #20... The change in
DraggableListBuilder.php
affectedLanguageListBuilder.php
as well.Rerolled the old patch, and made some additional changes to the patch to fix the errors in dependent classes.
Thanks!
- Status changed to Needs work
almost 2 years ago 6:02pm 24 January 2023 - 🇺🇸United States smustgrave
@ankithashetty thank you for working on this and good work!
Brought this up on #contribute with @andypost and agree that a change record would be best.
Also an IS update for the proposed solution.