The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India amanshukla6158
I have created patch for version 10.1.x, please review.
- Status changed to Needs review
almost 2 years ago 5:19am 15 February 2023 - Status changed to Needs work
almost 2 years ago 1:17pm 15 February 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 11:42am 27 February 2023 - 🇮🇳India TanujJain-TJ
Reviewed #45 with drupal: 10.1.x, the patch applied successfully and renamed views properties to core standards, but the $optionName is still not documented as stated in #15.
--- a/core/modules/views/src/Plugin/views/argument/Date.php +++ b/core/modules/views/src/Plugin/views/argument/Date.php @@ -41,7 +41,12 @@ class Date extends Formula implements ContainerFactoryPluginInterface { */ protected $argFormat = 'Y-m-d'; - public $option_name = 'default_argument_date'; + /** + * @todo Document this property. + * + * @var string + */ + protected $optionName = 'default_argument_date';
otherwise the patch looks fine, RTBC+1
- Status changed to Needs work
over 1 year ago 1:51pm 27 February 2023 - 🇫🇷France andypost
it needs work to provide backward compatibility, see 📌 In StylePluginBase Rename Views properties to core standards Needs work
- First commit to issue fork.
- Assigned to AditiVB
- @aditivb opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:58am 3 March 2023 - 🇮🇳India AditiVB
https://git.drupalcode.org/project/drupal/-/merge_requests/3576 Created this MR , Kindly review .
- Status changed to Postponed
over 1 year ago 3:34am 23 March 2023 - 🇳🇿New Zealand quietone
This is a coding standard fix and they are now done by sniff, not file. See 🌱 [meta] Fix Drupal.NamingConventions.ValidVariableName.LowerCamelName Active