[META] Rename Views properties to core standards

Created on 28 July 2013, almost 11 years ago

Updated 23 March 2023, over 1 year ago

Postponed until 8.1.x is open for development.

Do not change class properties that would make changes in .yml files.
Rename properties according to the new standard. "class properties should use lowerCamel naming" https://drupal.org/node/608152#naming
Convert property names exactly from underscore_separated to camelCase. So,
foo_the_bar
becomes
fooTheBar.
Change public to protected (depending whether the variable is used outside of the class).
Replace var with public/protected, see previous point.
Update the docblock for the properties to agree with https://drupal.org/node/1354#var

Before replacing any property names, we must check that the new name is not already in use.

If we change a public property name of a class, we need to change all uses of that property in other files as part of the issue.

Until all the issues are created, these instructions are here so they are in a central location.

Use this link to create a sub-issue for each of the below.
Edit this issue and add a link to the new sub-issue in the appropriate "Issue" column in this issue summary using the syntax [#nid@].
Only files that declare a class need to have issues created..

📌 Task

Status

Closed: duplicate

Version

10.1 ✨

Component

Views →

Last updated 1 minute ago

Created by

🇺🇸United States YesCT

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇫🇷France andypost
Filed 📌 In StylePluginBase Rename Views properties to core standards Needs work
Status changed to Closed: duplicate over 1 year ago3:24am 23 March 2023
Comment over 1 year ago →
🇳🇿New Zealand quietone New Zealand
After some more thought, I am going to close this issue dues to the reasons in #39 and transfer credit to the Meta for implementing the sniff, 🌱 [meta] Fix Drupal.NamingConventions.ValidVariableName.LowerCamelName Active . I am choosing duplicate as that seems the best fit.

Now, what to do with the children. The child issue will have changes that are still valid and credit should be given for that work, according to policy. For now, I will postpone them and make a comment on the new meta about them. That will prevent people from working on them until we have agreement on how to deprecate these properties.

Production build 0.69.0 2024