🇦🇹Austria @granik

Just in case, I've found a workaround.
Adding these lines into settings section of editor.editor.*.yml files fixed the issue for me:

plugins: {  }
toolbar:
  items: {  }

Many thanks to @anacolautti.

I'm currently having the same problem on 2.0.0-beta1, so I updated the issue metadata.
@icurk, thanks for your merge request, I tried to apply the diff and now the error is gone. I guess it's at least a workaround for the issue.

P.S. I've added the MR diff as a patch file here as well to simplify composer patching :)

Just added a new 1.1.x branch, as sanitizing/transliteration is availale since 10.2 as a core feature.
So, fixed in 1.1.x-dev, there will be a new beta-release soon.

Committed to 1.0.x branch.

Committed to 1.0.x branch.

granik → created an issue.

@nelo_drup, the patch #31 is up to date, just checked. The patch #11 is just a quicker solution with less code, but it's also applies without errors, just checked.

Thanks, merged.

@cboyden thanks for your catch!
The problem can be, that if you skip the validation in your case, the module will not check if node is published or not. I guess there should be a check like $node->isPublished(), instead just returning TRUE.

p.s. this check has been added just because of drupal moderation states(more info here), so in case if the regular published/unpublished status is used, there is no need to check the revision state. The code just checks all possible user cases.

I'll try to work on this issue as soon as possible.

New 2.0.x branch is now here. The dev-2.0.x release is available.

p.s. we cannot get rid of the enhancements submodule yet, because there is still no feature prevents popup close on click outside the modal window.

@2dareis2do, Drupal 10.1.8.
I think it has nothing to do with the drupal version. Actually an undefined service is used.

Added a patch for now.

granik → created an issue.

grienauer → credited granik → .

jjchinquist → credited granik → .

Thanks, comitted.

Committed.

Thanks to everyone, merged to 1.0.x.

@guedressel thanks for opening this issue, I haven't had enough time to support the module lately. I added D10 support now. I'll test if everything works good there and will make a new beta/rc release.

Fixed in dev version.

Fixed in dev version. Thanks, @Promo-IL for your catch.

granik → created an issue.

@paulrad, thanks four your MR, I just added a commit, now it seems to work fine.
Btw, X is now in provider list, thanks for your note, @kaszarobert.

p.s. Also added a patch to use with composer for now.

granik → made their first commit to this issue’s fork.

@Nelo_Drup, could you please add a bug report issue to file_rename → issue queue, because that module's feature was a prototype for file_replace patch. Better with steps to reproduce, thank you!

@Anybody, thanks. Just rebased, but would be ok if you test your new mailto feature again after my rebase.

Updated merge request, updated patch. See also last changes in File rename → module dev version.

Fixed in dev version. The check if file must be permanent is added when displaying the rename link.

Fixed in dev version.

Just pushed to dev version.

Fixed in dev version.

granik → created an issue.

@Nelo_Drup, the last one #27 is the latest. It has some issues with Seven-based admin themes. You can also try #11 or #14, it's the old one, but it seems to have no theme problems, but has potential D10 issues. You can apply only one of them.

I will work on this issue as soon as I have a bit more time for community work.

Thanks @greenSkin for your idea and your patch!
But I think it's much better to have rename link in action links directly. I just added some new code to *.module file, which provides a "rename" operation with permission check.

Added a patch, have not so much time to test if there is no mistakes, so will leave the status as it is, needs review. I hope it will be tested and moved to RTBC soon.

Thanks, committed to 1.0.x.

granik → created an issue.

Thanks everyone, committed.

Thx @niko- I updated the patch to replace field prefixes with placeholders. Because in case we use absolute urls the prefix makes some confuse, it's not needed for absolute urls.

granik → created an issue.

@jdhildeb thanks a lot for your patch. It's now committed to dev version.

@Berdir, thanks for your catch. I removed this deprecated requirements check via libraries module. Build folder check is still supported in runtime just for legacy reasons.

Version 2.0.0 has been released.

Thanks, Fixed in 2.0.x-dev.

Thanks, fixed in 2.0.x-dev.

Thanks everyone, fixed in 2.0.x-dev version.

@jdhildeb, thanks for creating this issue. I would say a good solution is adding a module setting "Rename link position" with options "under the widget" and "next to remove button". Also add a description that the second option can have display problems with non-claro themes. What do you think, is this a good solution?

Thanks, this feature has been added to dev version, a new release will be done.
Now shariff block is hidden if native share is supported.

Just committed, needs some testing if all code works with D10.

Fixed in dev version.

granik → created an issue.

Thanks @stred. But I guess you made a mistake in your patch, so it doesn't apply. I rerolled your patch and also added an interdiff.

The 'Replace' link is displayed on Claro theme but not on Seven for instance (D 9.5.9), tried to fix that but no luck.

I guess @plusproduit has the same issue. I have then to check it. Thx for the info!

I uploaded a new patch, just tested it on a website. It was just a typo in the comment. This hook is implemented.
I'm not sure how to describe steps to reproduce, The German letters are currently not shown in the glossary. I mean if the word starts with a German letter Ö, Ü or Ä it won't be displayed in the letters list,

Also found a related issue, the status is still active. I guess that's the reason.
https://www.drupal.org/project/drupal/issues/3195524 →
My workaround patch #2 works, but in this case still no results found.

I'm not sure why these characters cause a such error, maybe something wrong with search_api module is used (haven't checked with solr). I would need help here!

granik → created an issue.

Fixed, will release 1.0.1

granik → created an issue.

@plusproduit could you please provide some info about your environment? What drupal version do you use?

@alvar0hurtad0, nice catch, thanks! I removed this return statement as it's not needed at all here. Just checked with codesniffer and there are still no warnings.

https://git.drupalcode.org/project/file_rename/-/commit/80cc232e6236c8ff...

granik → created an issue.

@klausi, I think your suggestions are quite right. I've just pushed to repo, now the event is dispatched on form validation.
See my commit: https://git.drupalcode.org/project/file_rename/-/commit/13893901cac95bbf...
Thanks for your review!

@vishal.kadam Thanks for your review! I updated the repo, see the last commit please.

granik → created an issue.

Fixed in dev version.

granik → created an issue.

@Nelo_Drup, have you applied the right patch? The red button in the bottom comes from the old one (comment #11), I'm sure.
Look at the patch in the comment #16. Maybe cache flush is required.

@guardiola86 the uploaded file is renamed automatically, so the new file has the same name even though it was uploaded with another name. I think it's caching issue, so after replacing the widget shows the old file instead and sometimes the page force reload is required.

I think we don't need a message there, but I'm not sure how to solve this caching issue, maybe the cache tag of media should be invalidated?
Nice catch. Thanks, @guardiola86. So I'll change the status for now.

Update: I opened a merge request to add new features:

- now the inline link can be displayed for each inline widget separately
- module settings form added, inline link can be enabled for all widgets, overriding single widgets settings
- this also supported in D10

The replace link now looks like:

See File rename → module I maintain, these features also implemented there.

Also attach the patch just in case, to make possible to use it with composer.

Added a MR, @dejan0, should be checked.

granik → created an issue.