Remove calls to deprecated function libraries_get_path

In theory this would be considered a breaking change so it may also be a good time to switch the module to using the new semantic versioning branches and create a 2.x branch with releases there.

libraries_get_path() is from the contributed module and not Drupal 8.

The main thing to clean up here i to remove the conditional check for the libraries_directory_file_finder service, as that now always exists. In fact, that was added in Drupal 8.9, so it is enough to require at least 8.9, don't even have to drop support for Drupal 8.

bharath-kondeti → made their first commit to this issue’s fork.

Addressed #4 and updated the changes. Please review

More cleanup id possible, the default initializion and check is not needed as it will never be default. It's also not necessary to keep the hardcored libraries check. Just call the function and check for it being null

Please review.

Thanks everyone, fixed in 2.0.x-dev version.

FWIW, there's still more cleanup in shariff_requirements() that would make sense. It still talks about libraries module, it still has a == default check which no longer exists, so that whole block could be removed as it will never be true. the files that are checked at runtime and in the requirements hook and the explanation doesn't seem to be consistent (runtime supports dist, requirements hook does not).

@Berdir, thanks for your catch. I removed this deprecated requirements check via libraries module. Build folder check is still supported in runtime just for legacy reasons.

Automatically closed - issue fixed for 2 weeks with no activity.