Contrib.social

Fatal error if query contains whitespace and hyphen

Open on Drupal.org →
Created on 8 May 2023, about 1 year ago

Problem/Motivation

I got this error:

The website encountered an unexpected error. Please try again later.
TypeError: Drupal\search_api_page\Controller\SearchApiPageController::finishBuildWithoutResults(): Argument #2 ($result) must be of type Drupal\search_api\Query\ResultSetInterface, null given, called in /app/web/modules/contrib/search_api_page/src/Controller/SearchApiPageController.php on line 125 in Drupal\search_api_page\Controller\SearchApiPageController->finishBuildWithoutResults() (line 300 of modules/contrib/search_api_page/src/Controller/SearchApiPageController.php).

Steps to reproduce

Search query contains a " -" character set (whitespace and hyphen), although hyphen is added to ignored chars for search index. Not sure here.
My config(patch from comment #9 → from #3108496 → is applied):

Proposed resolution

Add a default NULL value for $result parameter in finishBuildWithoutResults method.

Remaining tasks

Review the patch.

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

🇦🇹Austria granik Vienna

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024