Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org ā†’
Created on 6 January 2024, 11 months ago
Updated 25 January 2024, 10 months ago

FILE: /app/block_condition_published/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
31 | WARNING | Line exceeds 80 characters; contains 101 characters
33 | WARNING | Line exceeds 80 characters; contains 100 characters
----------------------------------------------------------------------

FILE: /app/block_condition_published/src/Plugin/Condition/NodePublishedState.php
------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
14 | ERROR | [x] Doc comment star missing
117 | ERROR | [ ] Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
129 | ERROR | [x] Comment indentation error after @todo element, expected 3 spaces
130 | WARNING | [x] There must be no blank line following an inline comment
130 | WARNING | [ ] There must be no blank line following an inline comment
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------

Time: 46ms; Memory: 8MB

šŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

šŸ‡«šŸ‡·France abdei Paris, Ile de France

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @abdei
  • Comment 11 months ago ā†’
    šŸ‡«šŸ‡·France abdei Paris, Ile de France

    Hello,
    Heres a small patch for the PHPCS fix.

    Regards,
    Abdel

  • First commit to issue fork.
  • Status changed to Needs review 11 months ago
  • Comment 11 months ago ā†’
    šŸ‡®šŸ‡³India viren18febS

    I have tried to apply this patch but it is showing corrupted patch file.
    so i have resolved the issues and added a patch file , please review.

  • Status changed to RTBC 11 months ago
  • Comment 11 months ago ā†’
    šŸ‡µšŸ‡­Philippines clarkssquared

    Hi

    I applied patch #4 and I confirmed that it fixes the PHPCS issues and no PHPCS issues were reported

    āžœ  block_condition_published git:(1.0.x) curl https://www.drupal.org/files/issues/2024-01-09/issues-3412884-Fixed-the-issues-reported-by-phpcs.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2172  100  2172    0     0   4251      0 --:--:-- --:--:-- --:--:--  4300
patching file README.md
patching file 'src/Plugin/Condition/NodePublishedState.php'
āžœ  block_condition_published git:(1.0.x) āœ— ..
āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml block_condition_published 
āžœ  contrib git:(master) āœ—
  • Comment 11 months ago ā†’
    System Message
  • Comment 11 months ago ā†’
    šŸ‡¦šŸ‡¹Austria granik Vienna

    Thanks, committed to 1.0.x.

  • Issue was unassigned.
  • Status changed to Fixed 11 months ago
  • Comment 11 months ago ā†’
    šŸ‡¦šŸ‡¹Austria granik Vienna
  • Comment 10 months ago ā†’
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024