Rerolled patch #2 for 2.0.0-beta7
Patch reroll for 4.0.0-alpha5
version
Abhijith S → created an issue.
Patch #3 was not applying on 8.x-2.9. Attaching reroll patch for the same.
Abhijith S → made their first commit to this issue’s fork.
Addressed #12 Added typehint and seperate branch for 11x
Abhijith S → made their first commit to this issue’s fork.
Added test case for the issue #9 and changed to MR
I've been able to replicate the issue in my local D11.x. However its reseting to whatever Text format is at top position in the Text formats and editors (/admin/config/content/formats
) page, rather that reseting to Full HTML
only.
I've tried programmatically changing description. The MR !5880 fixed issue in my case.
Updated issue summary and also added typehint to return in MR
Hiding patches to avoid confusion.
Fixed the test failure in patch #27 (testViewUrlAsExternal
method) on MR.
Applied MR !5953 on D11.x.
The Export this config button is working fine which is redirecting to export config page with parameters os selected config entity.
However the Import to this config link is not implemented.
Abhijith S → made their first commit to this issue’s fork.
MR updated to 11.x
Patch #2 updated with test case.
Confirming this issue exits in Drupal 10.1. as well.
Tested on Drupal 11.x using MR 5819. The problem is solved after applying this patch
RTBC +1
Abhijith S → made their first commit to this issue’s fork.
Abhijith S → made their first commit to this issue’s fork.
Adding patch for the issue. Please review.
Adding patch for the issue. Please review.
The given proposed resolution removes the query parameter exists in the given URL(foo=1&bar=2
) and only keeps the new additional one like this:
https://hostname/path/?baz=3
.
Adding patch for keeping the all query parameters at once.
Fixed custom command failed issue.
Adding test for the issue.
Adding patch for this issue. Please review.
Abhijith S → made their first commit to this issue’s fork.
Got this issue when configured to use Basic Auth
Authorization method in client side.
It was working fine when I used Anonymous
Authorization method and set permissions accordingly.
Adding patch for this issue.
Abhijith S → made their first commit to this issue’s fork.
Created patch based on suggestion from #3. Please review.
Adding patch for the issue. Please review.
Adding test case for patch #9. Please review.
Applied MR !3838. The fieldname is displaying in the error message after applying this patch.
Attaching screenshots below.
Before patch:
After patch:
Applied the patch. Some issues are remaining after applying this patch.
FILE: access_records/access_records.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------
FILE: access_records/src/Form/AccessRecordForm.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
36 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------
FILE: access_records/src/Access/AccessRecordsRouteAccessCheck.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------
52 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
54 | WARNING | User::load calls should be avoided in classes, use dependency injection instead
64 | WARNING | Role::load calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------
FILE: access_records/src/Access/AccessRecordRevisionAccessCheck.php
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
126 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------
FILE: access_records/src/Plugin/Action/AccessRecordsActionDeriver.php
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------
72 | WARNING | Only string literals should be passed to t() where possible
73 | WARNING | Only string literals should be passed to t() where possible
-----------------------------------------------------------------------------------------------------
FILE: access_records/src/AccessRecordQueryBuilder.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
279 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------
FILE: access_records/src/AccessRecordFieldBuilder.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------
140 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
171 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
252 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------
FILE: access_records/src/EventSubscriber/AccessRecordsQueryAccessSubscriber.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------
79 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
91 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------
Applied the first patch. The phpcs issues are resolved in this patch.
RTBC +1
Confirming the patch fixes phpcs issues.
Applied MR !3. There are some more issues needs to be fixed.
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig,js,scss domain_registration
FILE: ...ax domain_registration/domain_registration.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ... domain_registration/domain_registration.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
8 | WARNING | Global constants should not be used, move it to a class or
| | interface
9 | WARNING | Global constants should not be used, move it to a class or
| | interface
--------------------------------------------------------------------------------
FILE: ... domain_registration/src/Tests/DomainRegistrationTest.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 16 WARNINGS AFFECTING 16 LINES
--------------------------------------------------------------------------------
35 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
36 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
53 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
54 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
71 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
72 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
89 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
90 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
107 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
108 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
125 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
126 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
144 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
145 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
162 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
163 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
Adding patch since the Serialized Data (Entity Share)
field Enhancer is not working in my case.
The Serialized Data (Entity Share)
field Enhancer is not working in my case .I'm using
layout paragraphs →
.
Getting this error while trying to pull layout paragraph pages. The paragraph reference field contents are not being transferred.
@tivi22 Field enhancer is set on both environments. But still getting the error.
Getting this error while trying to pull layout paragraph pages. The paragraph reference field contents are transferred.
Already tried the Serialized Data (Entity Share)
field Enhancer from this issue
https://www.drupal.org/project/entity_share/issues/3143003
✨
Compatibility with paragraph behaviors
Fixed
, but still getting this error while importing contents.
An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /batch?id=1166&op=do_nojs&op=do
StatusText: error
ResponseText: The website encountered an unexpected error. Please try again later.Symfony\Component\Serializer\Exception\UnexpectedValueException: The property 'layout_paragraphs' does not exist on the 'behavior_settings' field of type 'string_long'. Writable properties are: 'value'. in Drupal\jsonapi\Normalizer\FieldItemNormalizer->denormalize() (line 163 of core/modules/jsonapi/src/Normalizer/FieldItemNormalizer.php). Drupal\jsonapi_extras\Normalizer\JsonApiNormalizerDecoratorBase->denormalize(Array, 'Drupal\Core\Field\Plugin\Field\FieldType\StringLongItem', 'api_json', Array) (Line: 196)
Symfony\Component\Serializer\Serializer->denormalize(Array, 'Drupal\Core\Field\Plugin\Field\FieldType\StringLongItem', 'api_json', Array) (Line: 75)
Drupal\jsonapi\Serializer\Serializer->denormalize(Array, 'Drupal\Core\Field\Plugin\Field\FieldType\StringLongItem', 'api_json', Array) (Line: 65)
Drupal\jsonapi\Normalizer\FieldNormalizer->denormalize(Array, '\Drupal\Core\Field\FieldItemList', 'api_json', Array) (Line: 196)
Symfony\Component\Serializer\Serializer->denormalize(Array, '\Drupal\Core\Field\FieldItemList', 'api_json', Array) (Line: 75)
Drupal\jsonapi\Serializer\Serializer->denormalize(Array, '\Drupal\Core\Field\FieldItemList', 'api_json', Array) (Line: 85)
Drupal\jsonapi\Normalizer\ContentEntityDenormalizer->prepareInput(Array, Object, 'api_json', Array) (Line: 99)
Drupal\jsonapi\Normalizer\EntityDenormalizerBase->denormalize(Array, 'Drupal\paragraphs\Entity\Paragraph', 'api_json', Array) (Line: 45)
Drupal\jsonapi_extras\Normalizer\JsonApiNormalizerDecoratorBase->denormalize(Array, 'Drupal\paragraphs\Entity\Paragraph', 'api_json', Array) (Line: 16)
Drupal\jsonapi_extras\Normalizer\ContentEntityDenormalizer->denormalize(Array, 'Drupal\paragraphs\Entity\Paragraph', 'api_json', Array) (Line: 196)
Symfony\Component\Serializer\Serializer->denormalize(Array, 'Drupal\paragraphs\Entity\Paragraph', 'api_json', Array) (Line: 75)
Drupal\jsonapi\Serializer\Serializer->denormalize(Array, 'Drupal\paragraphs\Entity\Paragraph', 'api_json', Array) (Line: 169)
Drupal\jsonapi\Normalizer\JsonApiDocumentTopLevelNormalizer->denormalize(Array, 'Drupal\paragraphs\Entity\Paragraph', 'api_json', Array) (Line: 68)
Drupal\entity_share_client\Service\JsonapiHelper->extractEntity(Array) (Line: 454)
Drupal\entity_share_client\Service\ImportService->getProcessedEntity(Array) (Line: 279)
Drupal\entity_share_client\Service\ImportService->importEntityListData(Array) (Line: 257)
Drupal\entity_share_client\Plugin\EntityShareClient\Processor\EntityReference->importUrl(Object, 'http://ddev-test-web/jsonapi/node/landing/0f149313-1582-4a33-91ac-e63a1ac4c9db/field_component_content?resourceVersion=id%3A78700') (Line: 145)
Drupal\entity_share_client\Plugin\EntityShareClient\Processor\EntityReference->processEntity(Object, Object, Array) (Line: 297)
Drupal\entity_share_client\Service\ImportService->importEntityListData(Array) (Line: 55)
Drupal\entity_share_client\ImportBatchHelper::importUrlBatch(Object, 'http://ddev-test-web/jsonapi/node/landing?page%5Blimit%5D=50&filter%5Buuid-filter%5D%5Bcondition%5D%5Bpath%5D=id&filter%5Buuid-filter%5D%5Bcondition%5D%5Boperator%5D=IN&filter%5Buuid-filter%5D%5Bcondition%5D%5Bvalue%5D%5B0%5D=0f149313-1582-4a33-91ac-e63a1ac4c9db', Array) (Line: 295)
_batch_process() (Line: 137)
_batch_do() (Line: 93)
_batch_page(Object) (Line: 55)
Drupal\system\Controller\BatchController->batchPage(Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 270)
Drupal\shield\ShieldMiddleware->bypass(Object, 1, 1) (Line: 137)
Drupal\shield\ShieldMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 49)
Drupal\remove_http_headers\StackMiddleware\RemoveHttpHeadersMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 713)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
Applied patch #27 on 9.5.x.The Change layout option is appearing after applying this patch and its working fine.
However there is no visible separation between the Configure Section and Change layout links.It would be better if there is some space between them.
Attaching screenshot for reference:
Applied patch #242 on 9.4.x.The Remove
button appears which can be used to remove field items after applying this patch.
Attaching screen recordings for reference.
Applied patch #18 but its not adding class attribute to drupal-media
tag.
After patch:
Applied patch #220 and it works fine.
Before patch:
After patch:
RTBC +1