Calling Url::fromUri() with an uri having a query part and passing an additional query in the option parameter results in an invalid url

// Url with query $url = 'https://hostname/path/?foo=1&bar=2'; // Pass url and additional query parameter $url = \Drupal\Core\Url::fromUri( $url, ['query' => ['baz' => 3]] )->toUriString(); // Output: https://hostname/path/?foo=1&bar=2?baz=3 echo $url . PHP_EOL;

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 12 months ago →
🇩🇪Germany m.purc
Comment 12 months ago →
🇮🇳India Abhijith S
The given proposed resolution removes the query parameter exists in the given URL(foo=1&bar=2) and only keeps the new additional one like this:
https://hostname/path/?baz=3 .

Adding patch for keeping the all query parameters at once.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update 12 months ago
30,289 pass, 8 fail
Status changed to Needs work 12 months ago12:43pm 14 July 2023
Comment 12 months ago →
🇺🇸United States cilefen
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,707 pass, 11 fail
@rpayanm opened merge request.
Comment 12 months ago →
🇺🇾Uruguay rpayanm
I added # because we can have URL like this https://example.com?foo=1#my-string.
And tried to fix the tests.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,787 pass, 6 fail

Calling Url::fromUri() with an uri having a query part and passing an additional query in the option parameter results in an invalid url

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities