- 🇮🇳India Abhijith S
Applied MR !3838. The fieldname is displaying in the error message after applying this patch.
Attaching screenshots below.
Before patch:
After patch:
- Status changed to Needs work
over 1 year ago 3:37am 30 April 2023 - 🇺🇸United States smustgrave
Next step would be to add tests showing the issue.
- last update
over 1 year ago 29,368 pass, 1 fail - last update
over 1 year ago 29,374 pass - Status changed to Needs review
over 1 year ago 3:39pm 3 May 2023 - Status changed to Needs work
over 1 year ago 3:27pm 4 May 2023 - 🇺🇸United States smustgrave
Think the test should check the entire message. The fact the message changed and didn't break anything probably showed it wasn't being tested to begin with.
- Status changed to Needs review
over 1 year ago 7:07am 10 May 2023 - last update
over 1 year ago 29,380 pass - 🇮🇳India ranjith_kumar_k_u Kerala
The date format value in the error message is a dynamic one(The Field_label date is required. Please enter a date in the format 2023-05-10 05:19:38.), and the date format value is created on the basis of when the validateDatetime function is calling.
So I have added one more assertion to verify date format value is not empty and is in the following format "YYYY-MM-DD HH:MM:SS".
$this->assertMatchesRegularExpression('/^(\d{4})-(\d{2})-(\d{2}) (\d{2}):(\d{2}):(\d{2})$/', $arguments['%format']);
- Status changed to RTBC
over 1 year ago 10:47am 10 May 2023 - last update
over 1 year ago 29,383 pass - last update
over 1 year ago 29,388 pass - last update
over 1 year ago 29,388 pass - last update
over 1 year ago 29,388 pass -
justafish →
committed 1aaa480b on 11.x
Issue #3354606 by ranjith_kumar_k_u, pascalim, Abhijith S, smustgrave,...
-
justafish →
committed 1aaa480b on 11.x
- Status changed to Fixed
over 1 year ago 11:34am 18 May 2023 - 🇬🇧United Kingdom justafish London, UK
Committed 1aaa480b07 and pushed to 11.x. Thanks!
-
justafish →
committed 8d221fe1 on 10.1.x
Issue #3354606 by ranjith_kumar_k_u, pascalim, Abhijith S, smustgrave,...
-
justafish →
committed 8d221fe1 on 10.1.x
Automatically closed - issue fixed for 2 weeks with no activity.