Cannot discard layout builder changes with destination in URL query

Thanks for reporting.

Could use a small test case.

Confirming this issue exits in Drupal 10.1. as well.

Patch #2 updated with test case.

Recommend using MRs

Tried replicating this and I get redirected back to the node page, which seems correct.

On a fresh D11 install I'm also unable to replicate this.

Something else to flag is that on /admin/content on a fresh D11 install there is no layout action out of the box. So there may be a custom or contributed module that is interferring here.

Since steps to replicate were asked for over 3 months ago and nothing has been provided I'm marking this issue as closed. If you're able to provide steps to replicate please feel free to reopen or add a new issue.

Thanks!

@DanielVeza I am still able to reproduce it on a fresh Drupal 11 setup. Here are the steps:

• Navigate to a page /node/[nid]/layout?destination=[destination].
• Click "Discard changes".
• Get redirected to the [destination] page instead of /node/[nid]/layout/discard-changes

Here's an updated patch.

Here's the correct patch.

Will need to be an MR and have test coverage too

Thanks

Here you are @smustgrave!

Thanks removing tests tag with coverage here https://git.drupalcode.org/issue/drupal-3386094/-/jobs/1999033

Summary appears to be complete and manual testing proves it works as advertised.

LGTM

Ran the tests only feature since I couldn't replicate this in #9. Test fail as the steps to replicate have described, so I expect that was an issue in my local testing.

Code changes look good, I was debating if we should add a $this->getRequest()->query->has('destination') check around it, but since no other processing is being done to the destination I think it's safe to just run the remove.

$this->getRequest()->query->remove('destination'); does an unset of the param passed, if it doesn't exist there should be no issue.

Left a question on the MR

@larowlan believe that is correct. Way I understand is that the discard button is taking you back to /entity_test/1/layout vs /admin/content

The text only fail isn't going to admin/comment is what I'm saying