Contrib.social

Make Add content/media default publishing option descriptions consistent

Open on Drupal.org →
Created on 5 June 2023, over 1 year ago
Updated 9 November 2023, about 1 year ago

Problem/Motivation

When adding a new Content type (/admin/structure/types/add), the "Publishing options" for the "Published" and "Create new revision" options are as follows:

Published
Description: null

Create new revision
Description: Users with sufficient access rights will be able to override these options.

When adding a new Media type (/admin/structure/media/add), the "Publishing options" for the "Published" and "Create new revision" options are as follows:

Published
Description: Media will be automatically published when created. 

Create new revision
Description: Automatically create new revisions. Users with the "Administer media" permission will be able to override this option.

Steps to reproduce

Proposed resolution

The patch in #4 implemented the suggestion in #3, not the following.

Make the descriptions for the "Published" and "Create new revision" options consistent

Add new Content type:

Published
Description: Content will be automatically published when created.

Create new revision
Description: Automatically create new revisions. Users with the "Administer content" permission will be able to override this option.

Add new Media type:

Published
Description: Media will be automatically published when created. 

Create new revision
Description: Automatically create new revisions. Users with the "Administer media" permission will be able to override this option.

Remaining tasks

User interface changes

Before

After

API changes

Data model changes

Release notes snippet

📌 Task
Status

Needs work

Version

11.0 🔥

Component
Entity  →

Last updated about 10 hours ago

Created by

🇺🇸United States Chris Matthews

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

  • Needs subsystem maintainer review

    It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

  • Needs usability review

    Used to alert the usability topic maintainer(s) that an issue significantly affects (or has the potential to affect) the usability of Drupal, and their signoff is needed. When adding this tag, make it easy to review the issue. Make sure the issue summary describes the problem and the proposed solution. Screenshots usually help a lot! To get sign-off on issues with the "Needs usability review" tag, post about them in the #ux channel on Drupal Slack, and/or attend a UX meeting to demo the patch and get direct feedback from designers/UX folks/product management on next steps. If an issue represents a significant new feature, UI change, or change to the general "user experience" of Drupal, use Needs product manager review instead. See the scope of responsibilities for product managers.

Sign in to follow issues

Comments & Activities

  • Issue created by @Chris Matthews
  • Issue was unassigned.
  • Comment over 1 year ago →
    🇺🇸United States Chris Matthews
  • Comment over 1 year ago →
    🇬🇧United Kingdom andrew robinson

    I agree with the intention to make these options consistent.
    However, a user with only Edit permission for a content item is able to deselect the "Create new revision" checkbox when editing the item
    so the statement
    Users with the "Administer content" permission will be able to override this option.
    is misleading.

    The same applies for media.

    I propose changing the descriptions for the "Create new revision" options to:
    Automatically create new revisions. This option can be overridden when content is edited.
    and
    Automatically create new revisions. This option can be overridden when media is edited.

  • Comment over 1 year ago →
    🇮🇳India Abhijith S

    Created patch based on suggestion from #3. Please review.

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.2 & MySQL 8
    last update over 1 year ago
    29,559 pass
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States Chris Matthews
  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States smustgrave

    This is actually such a small change that I think it doesn't need a full usability group review. Will ask @lauriii though.

  • Comment over 1 year ago →
    🇫🇮Finland lauriii Finland

    I don't think this needs a full on usability review

  • Comment over 1 year ago →
    🇳🇿New Zealand quietone

    I am doing triage on the core RTBC queue → .

    This issue is changing the user interface so should be tagged 'usabiilty'. I'm adding the tag.

    I read the Issue Summary, the comments and the patch. There are no unanswered questions. The proposed resolution is not correct, the suggestion in #3 was taken.

    I decided to apply the patch and test. On Drupal 11.x, standard install. It works as stated in #3. I am uploading the screenshots I took.

  • Comment about 1 year ago →
    🇫🇮Finland lauriii Finland

    It looks like I filed a duplicate issue to this: 🐛 "Create new revision" is overridable regardless of permissions Needs review . I think it would be great to get are review that it's fine to change the description in the UI to match the current behavior instead of changing the behavior to match how the UI describes it.

  • Comment about 1 year ago →
    🇨🇭Switzerland berdir Switzerland

    Commented over there and basically came to the conclusion that I agree with updating the description. This issue doesn't seem to deal with sticky/promote flags yet, which also are currently controlled by the administer nodes permission (which is a super weird permission FWIW, since bypass node access and access content overview permissions have been split off from it it's really just all the cruft that didn't match the other two).

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States xjm

    Actually, I do think this needs UX review, because it's undoing a previous UX initiative's work to remove as many descriptions from forms as possible. In general, we should try to create a label that gives you all the information you need, and remove descriptions wherever possible. I really don't think "Published" needs a description, for example.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024