- Issue created by @nico.b
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 7:27am 30 November 2023 - Status changed to Needs work
about 1 year ago 7:44am 30 November 2023 The Needs Review Queue Bot โ tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request โ . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Merge request !5604Issue #3404901 by sijumpk: Fixing format getting overriding issue of setting description โ (Open) created by sijumpk
- Status changed to Needs review
about 1 year ago 7:54am 30 November 2023 - Status changed to Needs work
about 1 year ago 9:59am 30 November 2023 - ๐ธ๐ฐSlovakia poker10
Thanks for working on this. As this is bug, I think we would need to add a tests (according to the Steps to reproduce). Adding a tag.
Please use only one MR for further work.
- last update
about 1 year ago 30,611 pass - ๐ท๐บRussia zniki.ru
zniki.ru โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 1 year ago 1:31pm 5 December 2023 - ๐ท๐บRussia zniki.ru
Thanks for great issue summary.
I really enjoy the idea to be able to use array as argument for setDescription.
I created test case. - ๐ท๐บRussia zniki.ru
zniki.ru โ changed the visibility of the branch 11.x to hidden.
- Status changed to Needs work
about 1 year ago 2:24pm 5 December 2023 - ๐บ๐ธUnited States smustgrave
MR failure was a random javascript one,
Before marking this one can we figure out why setDescription is overriding the text format? Want to make sure we aren't masking a larger issue.
- ๐ท๐บRussia zniki.ru
Term description field is "text_long" type.
And for that type properties value, summary, format are supported.
Implementation of function setDescription just ignores other properties.
I think functions setDescription, getDescription, getFormat, setFormat can be removed in future, because in Node entity there are no such methods. - Status changed to Needs review
about 1 year ago 10:27am 19 December 2023 - Status changed to Needs work
about 1 year ago 2:40pm 19 December 2023 - ๐บ๐ธUnited States smustgrave
But then why do no other entities have this problem or do they?
Should be documented in issue summary why taxonomy is unique.
Also MR needs to be updated to 11.x as the current development branch.
- Assigned to zniki.ru
- ๐ท๐บRussia zniki.ru
I believe it came from D7 taxonomy module, then description was convert to text field, I find issues about it:
- #2016701: Expand TermInterface to provide methods โ
- #569434: Remove taxonomy term description field; provide description field for forum taxonomy โ
And part of last issue is to remove these methods.
- Merge request !5880Issue #3404901: Fixing format getting overriding issue of setting description โ (Open) created by zniki.ru
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 6:35pm 19 December 2023 - ๐ฎ๐ณIndia prashant.c Dharamshala
I tested the modifications locally, and in both scenarios, the functionality behaves as expected:
$term->setFormat('plain_text'); $term->setDescription('Test');
and
$term->setDescription('Test'); $term->setFormat('plain_text');
However, if no format is provided, like when excluding the code
$term->setFormat('plain_text');
, the system is storing theDescription
with the text format set asBasic HTML
. This behavior aligns with the expected outcome and does not match the description in the issue summary, where it is being saved asFull HTML
.Thank you.
- ๐ฎ๐ณIndia Abhijith S
I've been able to replicate the issue in my local D11.x. However its reseting to whatever Text format is at top position in the Text formats and editors (
/admin/config/content/formats
) page, rather that reseting toFull HTML
only.I've tried programmatically changing description. The MR !5880 fixed issue in my case.
- ๐ท๐บRussia zniki.ru
However its reseting to whatever Text format is at top position in the Text formats and editors
Do we want to check this settings during the tests?
And create a test case with changing the filters order? - Status changed to Needs work
10 months ago 2:55am 17 February 2024 - ๐บ๐ธUnited States smustgrave
In response to #21 believe that does need to be worked on. If the format saves as a different format that may be an issue. Hopefully doesnโt set to a format the user doesnโt have access to.