Novosibirsk
Account created on 11 May 2015, about 9 years ago
#

Merge Requests

Recent comments

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

This is still a problem, but in our case for nodes migration.

We need to migrate ~2 million nodes. At the beginning of the migration, ~10 nodes per second are imported. After 50k imported nodes, the speed becomes ~2 nodes per second.

I tried changing the batch_size in the migration, but it did not affect the migration speed at first glance.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

Please review MR

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

Here is the patсh with changes from #2.
But I agreed we need to add some toggle in module settings.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

We need to check if $entityAdapter is not null. It can be null if target entity not exists.

Right now I recieve error during reindex:
Error: Call to a member function getValue() on null in function Drupal\search_api\Utility\FieldsHelper->extractFields() (line 136 / /app/docroot/modules/contrib/search_api/src/Utility/FieldsHelper.php).

Sorry, I don't have possibility to create an interdiff right now.
Patch attached.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

qzmenko β†’ changed the visibility of the branch 6.0.x to active.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

qzmenko β†’ changed the visibility of the branch 6.0.x to hidden.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

+1 for this.
When using the "span" tag, the screen reader does not read aloud the information that the menu has been opened.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

Thanks for the work! Please check my notes to MR.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

Please test this patch.
I created it March, but I forgot to post it here. Sorry I don't have possibility to add interdiff at the moment.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

Social Auth 2.x is not supported already. We need to update this module for compatibility with Social Auth 3.x and for 4.x after that.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

I'll be happy to help with releasing the Drupal 9/10 compatible version.
Also I'm workin on fork of dependency https://github.com/rakeev/oauth2-mailru, because it using outdated API of Mail.ru
I will adopt this module for social_auth 3.x/4.x too.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

qzmenko β†’ made their first commit to this issue’s fork.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

Updated patch with small fixes.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

Updated patch with small fixes and improvements:

  1. Changed field type of IP Whitelist field from text to textareaa
  2. Changed type in config schema from text to string (text is wrong because this type is translatable)
  3. Added possibility to specify range of IP addresses
  4. Added validation for IP addresses and ranges
  5. Added update for create new config file
  6. Changed name of config file from flood_control.ip to flood_control.settings, because I think this config in future can contain settings related not only to IP whitelist
  7. Code style fixes
πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

Fatal error during enabling module using patch #17:
PHP Fatal error: Could not check compatibility between Drupal\content_sync\Logger\ContentSyncLog::log($level, Drupal\content_sync\Logger\Stringable|string $message, array $context = []): void and Drupal\Core\Logger\RfcLoggerTrait::log($level, Stringable|string $message, array $context = []): void, because class Drupal\content_sync\Logger\Stringable is not available in /app/web/modules/contrib/content_sync/src/Logger/ContentSyncLog.php on line 56

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk
πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk
πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

qzmenko β†’ created an issue.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

qzmenko β†’ created an issue.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

qzmenko β†’ made their first commit to this issue’s fork.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

Patch #6 is only suitable as a temporary solution, because it removes all messages on the page altogether.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

I have a site with two languages NL (default) and EN.
After running the migration via drush cim NL content is showing up in the the paragraphs on the english version of the node. I am expecting to see EN content here.

Yes, I confirm that problem. The content of the paragraphs of the original node was copied, instead of the translated paragraphs.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

Has any other more up-to-date conversion method appeared during this time, other than the one described here?

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

Please check MR!10 (https://git.drupalcode.org/project/color_field/-/merge_requests/10)

  • Merged 3.x branch
  • Resolved conflicts
  • Fixed issue with label
  • Use new drupal/once library
πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk
// Hide the widget labels if the widgets are being shown.
if (!spectrum_settings.showInput || !spectrum_settings.showAlpha) {
  $element.find('label').hide();
  $element_opacity.hide();
}

Maybe I don't understand something, but it seems to me that the Label of the field should always be displayed? It's not clear why label of field hidden if "input" hidden.

Otherwise, everything works well and the new widget looks better than the existing ones.

πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

Merged, thanks!

Production build 0.69.0 2024