Support entity types without revisions

Created on 21 December 2023, 12 months ago

Updated 15 January 2024, 11 months ago

I extending abstract class EntityTitleLength for another entity type. For this entity type revisions not enabled.

During module enabling I recieve next error:
Undefined table: 7 ERROR: relation "{entity_type}_relationship_field_revision" does not exist

This error because of method changeLength() doesn't check if revisions for entity enabled.

I suggest to:

Check if entity is revisionable
Get revision data table using $entity_type_definition->getRevisionDataTable()
Make injected properties with dependency injections protected instead of private for anyone who would like override changeLength method and reuse injected dependencies.

✨ Feature request

Status

Fixed

Version

2.0

Component

Code

Created by

🇷🇺Russia qzmenko Novosibirsk

Live updates comments and jobs are added and updated live.

Merge Requests

!1Support entity types without revisions
Merged
🇷🇺Russia qzmenko
updated 11 months ago

Issue created by @qzmenko
Merge request !1Support entity types without revisions → (Merged) created by qzmenko
Status changed to Needs review 12 months ago1:32pm 21 December 2023
Comment 12 months ago →
🇷🇺Russia qzmenko Novosibirsk
https://git.drupalcode.org/project/title_length/-/merge_requests/1
Comment 11 months ago →
🇪🇸Spain cbccharlie
Thanks @qzmenko. I just integrated your changes and generated a stable version 2.0.0.
Status changed to Fixed 11 months ago5:02pm 15 January 2024
Comment 11 months ago →
🇪🇸Spain cbccharlie
Status changed to Fixed 11 months ago5:02pm 15 January 2024
Comment 11 months ago →
🇪🇸Spain cbccharlie

Production build 0.71.5 2024