- First commit to issue fork.
- last update
over 1 year ago PHPLint Failed - π·πΊRussia qzmenko Novosibirsk
qzmenko β changed the visibility of the branch 6.0.x to hidden.
- π·πΊRussia qzmenko Novosibirsk
qzmenko β changed the visibility of the branch 6.0.x to active.
- π©πͺGermany Grevil
grevil β changed the visibility of the branch 6.0.x to hidden.
- π©πͺGermany Grevil
Rebased the issue forks issue branch.
Here is a static patch from the rebased MR.
- π©πͺGermany Grevil
grevil β changed the visibility of the branch 6.0.x to active.
- π©πͺGermany Grevil
Ok, the current implementation doesn't work anymore. "migrationsList()" is already implemented, and once removed, the "_construct()" method throws the next error, expecting less parameters, and the list probably goes on after this, seeing the changes made by @imash in 6.0.x. But those changes seem too much? Unsure about this. Either way also using the updated 6.0.x by @imash and adjusting the namespace also throws an error when migrating:
[error] Error: Call to a member function getMigrationDependencies() on array in Drupal\migrate_tools\Drush\Commands\MigrateToolsCommands->importParallel() (line 1022 of /var/www/html/web/modules/contrib/migrate_tools/src/Drush/Commands/MigrateToolsCommands.php) #0 [internal function]: Drupal\migrate_tools\Drush\Commands\MigrateToolsCommands->importParallel()
And generally I don't think this is the correct approach for parallel migration, as we implement a new standalone "migrate:import-parallel" command, instead of extending the existing "migrate:import" command and adding a "--parallel" flag. I understand that this isn't easily implemented, but in the current implementation we drop crucial flags like "--continue-on-failure" or "--group=...", which at least for us, is a no-go.