Automated Drupal 10 compatibility fixes

Given that #3 explicitly drops support for Drupal 8 in the info.yml file, the whole EventProxy thing that supports Symfony 3 and 4 concurrently is unnecessary.

There are also numerous problems with the patch in #3 that would make a site fail with fatal errors.

1. The Event Dispatcher service's dispatch method has changed.
2. drupal_get_path has been removed from Drupal 10.

Reviews can/should not be based on whether a patch applies. The bot wouldn't have posted a patch if it did not apply.

Quality reviews should be based on real user testing of the module.

That all said, I've updated the patch such that I was able to confirm that:

1. The admin form loads properly
2. A social media field can be added to a node and toggled on/off with the expected results
3. A social media block can be added to a theme region and displays appropriately

No interdiff here. The original patch didn't really work.

This module could use some automated tests!

Setting NR for #9

I have reviewed the patch in comment #12 , it got applied successfully.
There are no compatibility errors found , thus moving the issue to RTBC.

Hi @Chandra Gowsalya Kannan, I've taken a look at #12 and have made some observations:

1. I don't think that the interdiff between #9 and #12 matches. #9 adds this line.

+    $this->eventDispatcher->dispatch($event, 'social_media.add_more_link');

Your interdiff is seemingly removing this line:

-    $this->eventDispatcher->dispatch('social_media.add_more_link', $event);

which simply doesn't exist in #9.

2. We should be using the dependency injected dispatcher service instead of instantiating a new one.

Given the timeline and the degree of manual testing I've performed against #9, and given no evidence of manual testing against #12 and #13, I'm planning on committing #9 to the 2.0.x branch.

Luke.Leber → credited charlie59 → .

Luke.Leber → credited endless_wander → .

Luke.Leber → credited Hong Cai → .

Luke.Leber → credited neschi → .

Luke.Leber → credited qzmenko → .

Luke.Leber → credited Tritof → .

Luke.Leber → credited Vinay15 → .

Added additional issue credits from #3178056.

Luke.Leber → credited allanforms → .

Luke.Leber → credited amarlata → .

Copying over issue credits from #3169074 (outdated).

Automatically closed - issue fixed for 2 weeks with no activity.