Add seballot/spectrum colorpicker

Created on 3 February 2022, over 2 years ago
Updated 9 February 2023, over 1 year ago

Problem/Motivation

Having a modern and actively maintained colorpicker would be a good thing. see seballot/spectrum

Remaining tasks

Review patch, comment / alter and commit

✨ Feature request
Status

Needs review

Version

3.0

Component

Code

Created by

πŸ‡¦πŸ‡ΉAustria attisan Vienna

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk
    // Hide the widget labels if the widgets are being shown.
    if (!spectrum_settings.showInput || !spectrum_settings.showAlpha) {
      $element.find('label').hide();
      $element_opacity.hide();
    }

    Maybe I don't understand something, but it seems to me that the Label of the field should always be displayed? It's not clear why label of field hidden if "input" hidden.

    Otherwise, everything works well and the new widget looks better than the existing ones.

  • @qzmenko opened merge request.
  • πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk

    Please check MR!10 (https://git.drupalcode.org/project/color_field/-/merge_requests/10)

    • Merged 3.x branch
    • Resolved conflicts
    • Fixed issue with label
    • Use new drupal/once library
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • πŸ‡·πŸ‡ΊRussia qzmenko Novosibirsk
Production build 0.69.0 2024