- First commit to issue fork.
- 🇨🇦Canada dylan donkersgoed London, Ontario
Dylan Donkersgoed → made their first commit to this issue’s fork.
- Merge request !25Resolve #2056683 "Add the possibility to white list specific ips" → (Open) created by dylan donkersgoed
- last update
about 1 year ago 10 fail - Status changed to Needs review
about 1 year ago 9:15pm 28 May 2024 8:20 3:27 Running- 🇨🇦Canada dylan donkersgoed London, Ontario
I opened a new MR with a patch for the 2.x version. Patch is attached as well.
The last submitted patch, 6: 2056683-add-the-possibility.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- 🇨🇦Canada bdunphy
This is a much needed feature for Login Security. I've done some basic testing with the patch in #6 and this works well. What is needed to get this moving forward?
- 🇨🇦Canada bdunphy
In #6, in the patch I noticed that
explode()is used to split the IP addresses string into a list. This doesn't handle whitespace around commas which I've found that some on our team have a tendency to add. I've updated the 2.X patch locally withpreg_split('/[\s,]+/', $list)instead ofexplode()and tested with success. I'd be happy to help here getting this issue completed / closed.