πŸ‡΅πŸ‡±Poland @besek

Account created on 12 July 2012, almost 12 years ago
#

Recent comments

πŸ‡΅πŸ‡±Poland besek

Ok, thanks for clarification and the patch. I was testing mr on rc11 and it worked fine, so I thought this would be enough to use it as a patch.

πŸ‡΅πŸ‡±Poland besek

@DuaelFr, there are small differences between your patch and what is in mr. Can you please clarify them? I'm wondering what is the goaald and which one should be used for patching RC11 on my website

πŸ‡΅πŸ‡±Poland besek

I didn't check with Inline Entity Form, but just in case I tested compatibility with other modules, where it could potentially impact behaviour:
- Views Bulk Operations
- Views Entity Form Field
- Dashboards with Layout Builder
All of them seems to be working fine, with or without this patch :)

πŸ‡΅πŸ‡±Poland besek

Just tested in linked issue. I think this one can be closed as Duplicate?

πŸ‡΅πŸ‡±Poland besek

Thank you @hundri! I've verified your fix and it works very well!

πŸ‡΅πŸ‡±Poland besek

I have the same issue :(
I was trying to disable this new feature (which is great, if it would work on modal forms) by disabling option "Enable sticky action buttons" in Gin settings. However disabling this option didn't change anything.
For now, only option I found to make those modal forms work was downgrading gin to RC10

πŸ‡΅πŸ‡±Poland besek

Thanks @CRZDEV
Patch from #7 πŸ› Declaration of Drupal\search_api_solr\Plugin\search_api\backend\SearchApiSolrBackend::__sleep() must be compatible Active works well. Although its name is bit confusing, because it suggests patch is form search_api_solr, while it is for search_api :)

After upgrade of Search API to 8.x-1.35 I could get everything to work correctly after applying two patches:
https://www.drupal.org/project/search_api_solr/issues/3449292 πŸ› Fatal error Declaration of Drupal\search_api_solr\Plugin\search_api\backend\SearchApiSolrBackend::__sleep() Fixed for Search API SOLR
https://www.drupal.org/project/search_api/issues/3454939#comment-15642321 πŸ› Declaration of Drupal\search_api_solr\Plugin\search_api\backend\SearchApiSolrBackend::__sleep() must be compatible Active for Search API

Looks like both modules needs to be released to have those issues covered in Drupal<11

πŸ‡΅πŸ‡±Poland besek

I had the same issue and I've installed patch from https://www.drupal.org/project/search_api_solr/issues/3449292 πŸ› Fatal error Declaration of Drupal\search_api_solr\Plugin\search_api\backend\SearchApiSolrBackend::__sleep() Fixed
After installing patch, the error changed to:

PHP Fatal error:  Declaration of Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeup() must be compatible with Drupal\search_api\Backend\BackendPluginBase::__wakeup(): void in /var/www/html/web/core/lib/Drupal/Core/DependencyInjection/DependencySerializationTrait.php on line 74

Fatal error: Declaration of Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeup() must be compatible with Drupal\search_api\Backend\BackendPluginBase::__wakeup(): void in /var/www/html/web/core/lib/Drupal/Core/DependencyInjection/DependencySerializationTrait.php on line 74
πŸ‡΅πŸ‡±Poland besek

#6 works fine with D 10.2.6 and beta10.
The only potential issue I see here is that it doesn't check the content workflow permissions and even if current user doesn't have permission to keep node in current state, it allows them to do it.
I guess it is ok, as long as it is know to the users?

I hope it will be included in the release soon! :) Thanks @sokru

πŸ‡΅πŸ‡±Poland besek

I can confirm, I also had this issue because of the patch from πŸ› Fix PHP 8.2+ deprecation notices Closed: duplicate . Removal of this patch solved the problem.

πŸ‡΅πŸ‡±Poland besek

I've tested patch #17 on Drupal 10.2.6 with Views Data Export 8.x-1.4 and it works really nice, thanks @erom.

πŸ‡΅πŸ‡±Poland besek

I can confirm, patch from #4 works perfect, thanks!

πŸ‡΅πŸ‡±Poland besek

I'm using this module on Drupal 10.2.5 and it works fine.
@marcoka if, in your case, it works on one site, but it doesn't on another, you should check if any other modules or configuration are causing conflict. And maybe than provide more info for this ticket

πŸ‡΅πŸ‡±Poland besek

I'm using patch #5 with Drupal 10.2.4 and it works fine. It is not causing any issues while editing nodes with workflow

πŸ‡΅πŸ‡±Poland besek

@gilbertdelyon please check workaround I suggested here: https://www.drupal.org/project/media_library_edit/issues/3264180#comment... ✨ Enable Media Edit with inline media entities within text fields using CKEditor WYSIWYG Active

πŸ‡΅πŸ‡±Poland besek

I also think it would be good feature, otherwise it's hard to explain content editors that they need to go somewhere else to edit image.
In the meantime I'm using "Media Library Edit" module together with https://www.drupal.org/project/edit_media_modal β†’ . Both modules work fine together, although it would make much more sense to have both features in one module :)

πŸ‡΅πŸ‡±Poland besek

I had the same issue and from solutions in #21 only disabling cache had positive effect. Patch from "nojs"/"ajax" route parameter in use-ajax link breaks CSRF protection πŸ› "nojs"/"ajax" route parameter in use-ajax link breaks CSRF protection Needs work unfortunately didn't help

πŸ‡΅πŸ‡±Poland besek

@occupant, thanks, I've tested it and it really looks like it if working well now. Thank you!

πŸ‡΅πŸ‡±Poland besek

Ok, so as weird as it might be - I didn't have this issue on Drupal 9, but after the upgrade to Drupal 10, I have exactly the same issue as kriboogh.

πŸ‡΅πŸ‡±Poland besek

Thanks _tarik_, your solution worked for me well!
I bumped into another problem when this started to work: https://www.drupal.org/project/draggableviews/issues/3408185 πŸ› Save order button removed if bulk operations in view (by claro) Active , but I think it actually is a seperate issue

πŸ‡΅πŸ‡±Poland besek

I have the same issue, using Gin theme (button to Saver order is not removed, however is inactive until any item on the list is selected)

πŸ‡΅πŸ‡±Poland besek

besek β†’ created an issue.

πŸ‡΅πŸ‡±Poland besek

Thanks for the answer. I was testing on:

  • Drupal 9.5.11
  • Gin 8.x-1.0-rc4
  • maxlength v2.1.2
  • CKEditor5 Fullscreen v1.0.0-beta5

I've noticed some time ago, weird behaviour of maxlength. The counter is, as you described, right below the textarea when I'm creating new node. And fullscreen button works fine. However, when I save node and edit it again, the counter from maxlength is above the textarea and at this moment, fullscreen button is not working anymore.

I'm not sure why maxlength div is displayed in two different places, but I hope this description would help you to verify if this conflict should be resolved in CKEditor5 Fullscreen module?

Thanks!

πŸ‡΅πŸ‡±Poland besek

Thanks @zanvidmar. Workaround sugested by you is less ugly than patch I used :)

πŸ‡΅πŸ‡±Poland besek

besek β†’ made their first commit to this issue’s fork.

πŸ‡΅πŸ‡±Poland besek

I had the same issues, with very similar steps to reproduce as described in #5 πŸ› Ajax error on views with aggregation Postponed: needs info .
Patch from #2 πŸ› Ajax error on views with aggregation Postponed: needs info wroked well for me.

πŸ‡΅πŸ‡±Poland besek

I think I got the same problem. Applying coupon from the promotion didn't change the total price in order checkout form. However, the new price was visible after page refresh.

πŸ‡΅πŸ‡±Poland besek

Ok, this is actually correct. I thought it was working in Drupal 7 by default, but I've realised that I was actually using module https://www.drupal.org/project/wysiwyg_linebreaks β†’ (currently supporting D9, but not CKEditor 5)

Thanks for explanation!

πŸ‡΅πŸ‡±Poland besek

#80 worked for me, however it saevd node title as image alt. I think it should be configurable so you can choose what values you want to save in title and alt fields of the image. Thanks

πŸ‡΅πŸ‡±Poland besek

I'm sending extremly simple and temporary patch for those fields. It's not final solution of course, it is workaround if someone lost upload fields
https://www.drupal.org/files/issues/2023-07-04/simpleads-disapearing_fie... β†’

πŸ‡΅πŸ‡±Poland besek

This fix from Tamper module:
https://www.drupal.org/project/tamper/issues/3119301 ✨ Skip tamper if item is empty Fixed
might be good solution. It provides new tamper "Skip tampers on empty". I've added this tamper to every field that I'm trying to manipulate and it works fine

πŸ‡΅πŸ‡±Poland besek

Ok, I actually just resolved my issue: it was caused by empty line in my MYTHEME.theme file. But it might be also another file in theme. It's worth to verify if it's somewhere in the theme by switching to default theme and checking if error still occurs. I'm leaving it here, as it may help somebody.

πŸ‡΅πŸ‡±Poland besek

Anyone found solution of this issue? I have the same problem and can't find what is causing it

πŸ‡΅πŸ‡±Poland besek

I honestly don't know if it is thanks to the version 2.1.2 or Drupal core upgrade, but DraggableViews for custom blocks is now working for me.

Production build 0.69.0 2024