🇨🇦Canada @geoanders

Thanks for bringing this to our attention. Fix now merged into 2.x branch.

Thanks for this fix. Now merged into 2.x branch.

@hktang

I will give it a review hopefully over the next few days and get this merged in.

Thanks again!

Thanks!

This will be fixed in the next release.

Relevant changes merged into branch.

Possibly access/permission issues on those specific content types?

Did you clear cache/etc and see if they show up?

Both modules essentially provide a weight field that is added to the entity/node and used for ordering in views/etc.

I think the biggest difference would be the out of box ordering interface that this module offers. Node weight is particularly focused on nodes in this case.

I have tested on my D10 instance and seems fine.

Goto /admin/structure/node-weight to enable content types. In my case, I have two "Article" & "Basic Page". I have enabled both.

I see articles and can order here: /admin/structure/types/manage/article/order
I see pages and can order here: /admin/structure/types/manage/page/order

Not sure what your issue is, but I can't seem to reproduce the issues your having.

Now fixed in 1.0.1 release.

Thanks!

Closing as the offered change is not needed/shouldn't impact D10 operations.

Thanks. Now merged in.

Good catch!

If you can provide a patch for this issue, we can get that merged in asap.

Thanks!

#6 seems like the correct fix here.

More information on the matter: https://www.php.net/manual/en/class.allowdynamicproperties.php

Now merged in. Thanks for the fixes.

@yasheshb

Try changing the module composer line to this:

"npm-asset/ckeditor--ckeditor5-page-break": ">=35.4"

Let me know if that works.

@madelyncruz

Opened a issue/ticket to make Color module optional.

geoanders → created an issue.

D10 fixes are applied against 2.x branch and not 1.x. Marking as fixed.

Thanks!

Please apply against 2.x branch.

@mellowtothemax

1.0.3 should address this issue.

If you are on D10, use 2.0.0 release.

@madelyncruz

Tested for the unpack issues, but can't seem to reproduce. Tried on both 9.5 and 10. Seems to work fine on my end.

Reviewing the _color_unpack() issue, as the function does exist in the color module. The other issues have been addressed.

Good catch. Now merged in.

This might need some config options for stripping all html or have allowable elements to not be stripped.

Currently all tags are stripped.

Now merged in. Thanks!

Closing as the fix is in dev. Will make a release soon for this.

Thanks for the review. Marking as fixed.

Pushed fix to repo. Just needs review.

@pankajlogical

In most typical use cases, unpublished probably doesn't need it, but would like to leave it configurable as someone might require a different use case.

@pankajlogical,

I think we should make this a configuration item, as some might want both options.

Thanks for this. Definitely a good idea. I will review and test when I get a moment.

greggles → credited geoanders → .

greggles → credited geoanders → .

Thanks. Now merged in.

Thanks. Now merged in.

Thanks. Now merged in.

geoanders → made their first commit to this issue’s fork.

geoanders → made their first commit to this issue’s fork.

geoanders → made their first commit to this issue’s fork.

This should be fixed in 8.x-4.6 release.

The fix was introduced a few months ago, but never got released.

Closing this ticket.

Thanks for this. Now merged in.

Fixed in 1.0.2 release.

This will need to be applied against 3.x branch.

https://www.drupal.org/project/color →

Changes rolled into 3.x branch/release. Thanks!

Now merged in. Thanks!

Thanks for the patch. Probably will need a 3.x branch to support 9.3 and up, since this will change the version constraints in this case.

Considering I opened the issue, I should have the ability to close it. Specially since if someone else decides obtain maintainership, they will need to open their own issue/ticket. Doesn't make sense to me to keep this open any longer, but do what you will with it.

Either way, this issue can be closed by the powers that be.

Closing out request as maintainer is bringing on another person to maintain the module.

Drupal 10 support code changes in repo. Just needs review and release.

Drupal 10 code changes in repo. Needs review and release.