Remove Unpublished Node from node order form

Applied a patch to fix the problem

Thanks for this. Definitely a good idea. I will review and test when I get a moment.

@pankajlogical,

I think we should make this a configuration item, as some might want both options.

Addressed #5 and updated the changes. Please review https://git.drupalcode.org/project/node_weight/-/merge_requests/3

Yes, @geoanders that would be great if made this a configuration item. But I am sure unpublished node doesn't need weight as they will not show on the website.

Thank you @bharath-kondeti updated changes as per @geoanders suggestion.

@pankajlogical

In most typical use cases, unpublished probably doesn't need it, but would like to leave it configurable as someone might require a different use case.

Automatically closed - issue fixed for 2 weeks with no activity.

Hi @geoanders, I've reviewed and tested the new feature Include Unpublished Nodes implemented in the module for including/excluding unpublished nodes from Manage Order form for changing the node weight. After the implementation of the new feature, getting below errors while visiting /admin/structure/types/manage/{content_type}/order page.

The website encountered an unexpected error. Try again later.

TypeError: Drupal\Core\Entity\EntityStorageBase::loadMultiple(): Argument #1 ($ids) must be of type ?array, Drupal\Core\Entity\Query\Sql\Query given, called in /app/web/modules/contrib/node_weight/src/Form/NodeOrderForm.php on line 130 in Drupal\Core\Entity\EntityStorageBase->loadMultiple() (line 269 of core/lib/Drupal/Core/Entity/EntityStorageBase.php).

Also on /admin/structure/node-weight module configuration page the Include Unpublished Nodes checkbox value is not being updated after clicking on the checkbox. The checkbox for this field is always rendered as checked/enabled even if you have unchecked and saved the configuration. I've attached before and after screenshots and video clips for all the issues encountered after the new feature implementation.

I've fixed the issue and created a patch → for the issue fixes as only maintainers can reopen the Closed (Fixed) issue. Please review the changes.

Thanks

@geoanders please review it, As it is causing an error to this: https://www.drupal.org/project/node_weight/issues/3448536 ✨ Only allows ordering up to 201 nodes Needs review