- Issue created by @madelyncruz
- First commit to issue fork.
- 🇮🇳India dineshkumarbollu
Hi
For D10 composer.json file already exists in codebase and for d9 site signature works fine in my local.
- 🇵🇭Philippines madelyncruz
Hi dineshkumarbollu,
Thank you for your quick response. I didn't realize that the same issue had been fixed two weeks ago. Is the update applicable to 3.x version or does it require a specific module version? I can't find the updates on composer.json and inyo.yml files in my local and here - https://git.drupalcode.org/project/signature_field/-/blob/3.0.0/composer...
- 🇵🇭Philippines madelyncruz
Upon checking further, it appears that the update is still on 3.x-dev. I'm also looking at this thread -> https://www.drupal.org/project/signature_field/issues/3359970 🐛 Dependency to deprecated Color module Fixed . I agree to make the color module optional. If it's not available, we can use a regular text field instead. Do you think this is possible? I believe we don't need a fancy UI to define the hex color because usually only web developers will be managing the site structure .
- Status changed to Closed: duplicate
over 1 year ago 11:16am 17 July 2023 - 🇨🇦Canada geoanders Nova Scotia 🍁
Closing as the fix is in dev. Will make a release soon for this.
- Status changed to Needs review
over 1 year ago 12:26pm 19 July 2023 - 🇨🇦Canada geoanders Nova Scotia 🍁
Reviewing the _color_unpack() issue, as the function does exist in the color module. The other issues have been addressed.
- 🇨🇦Canada geoanders Nova Scotia 🍁
@madelyncruz
Tested for the unpack issues, but can't seem to reproduce. Tried on both 9.5 and 10. Seems to work fine on my end.
- Status changed to Fixed
over 1 year ago 12:54pm 19 July 2023 - 🇵🇭Philippines madelyncruz
Hi geoander,
Thank you for your response and for the testing. We're working with a shared codebase, and I noticed there's a patch → in our composer.json file related to the Fix from #68 for color in 9.4.x with PHP 8.1 deprecation fix in rgbToHex() 🐛 Color css files are not regenerated when deploying through configuration management Needs work comment. The patch removed several functions, including the
_color_unpack()
function. I can't remove the patch because it was added by other developers to fix the issue with generating CSS files.I was wondering if it's possible to make the color module optional, just like your initial proposal from the other related issue. I'd really appreciate hearing your suggestions on this matter.
- 🇨🇦Canada geoanders Nova Scotia 🍁
@madelyncruz
Opened a issue/ticket to make Color module optional.
Automatically closed - issue fixed for 2 weeks with no activity.