Unreliable DOM selector

Created on 7 June 2023, over 1 year ago

Problem/Motivation

The DOM selector in the JS file isn't always reliable. It relies on classes that can easily be changed in a theme. For instance, I was not able to get this module to work on a theme based on the core Stable theme.

Steps to reproduce

Enable a theme based on stable.

Proposed resolution

Update the DOM selector to use core classes from Views that cannot be changed.

Remaining tasks

Create and test patch.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇺🇸United States pianomansam

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @pianomansam
Comment over 1 year ago →
🇺🇸United States pianomansam
Attaching possibly related issue ✨ Should refresh work on the view block displays? Active
@pianomansam opened merge request.
Status changed to Needs review over 1 year ago4:24pm 7 June 2023
Comment over 1 year ago →
🇺🇸United States pianomansam
I've created an issue fork and merge request to resolve this. I've tested this on both page and block view displays.
First commit to issue fork.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024